STRY0020817 - Manually update gene-drug key database#250
Merged
Conversation
apetkau
approved these changes
Jun 2, 2026
apetkau
left a comment
Member
There was a problem hiding this comment.
This looks really great Eric 😄. Thank you. I have one requested change (below) but have approved the overall PR.
Requested change
- Could you update the version of the gene-drug keys from
032525to032525.1? In the past, I had been adding a minor version number after the date so indicate we've modified the gene-drug key from the Excel file we were sent. These versions are specifically stored in:staramr/staramr/databases/resistance/data/info.ini
Lines 1 to 3 in 472031f
Member
Author
Updated in 598ef25 Only the Resfinder gene-drug key was modified though, so I only updated that version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
StarAMR's gene-drug database is missing entries corresponding to IDs within the CGE Resfinder database. These are primarily variants of existing genes. We need to add this missing IDs to the gene-drug key to prevent unknown[...] from being reported.
Acceptance Criteria