Skip to content

STRY0020817 - Manually update gene-drug key database#250

Merged
emarinier merged 4 commits into
developmentfrom
update_gene_drug
Jun 3, 2026
Merged

STRY0020817 - Manually update gene-drug key database#250
emarinier merged 4 commits into
developmentfrom
update_gene_drug

Conversation

@emarinier

@emarinier emarinier commented May 28, 2026

Copy link
Copy Markdown
Member

Description

StarAMR's gene-drug database is missing entries corresponding to IDs within the CGE Resfinder database. These are primarily variants of existing genes. We need to add this missing IDs to the gene-drug key to prevent unknown[...] from being reported.

Acceptance Criteria

  • Add corresponding entries for the missing phenicol FloR and phenicol CmlA.
  • Note the capitalization differences in gene IDs from previous entries. The newer entries in the CGE database have different capitalization than the old entries. We will probably need to match these differences correctly.
  • Test that the new and old floR/FloR and cmlA/CmlA are being handled correctly.

@emarinier emarinier self-assigned this May 28, 2026
@emarinier emarinier changed the title Adding Missing gene-drug Entries STRY0020817 - Manually update gene-drug key database Jun 2, 2026

@apetkau apetkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great Eric 😄. Thank you. I have one requested change (below) but have approved the overall PR.

Requested change

  1. Could you update the version of the gene-drug keys from 032525 to 032525.1? In the past, I had been adding a minor version number after the date so indicate we've modified the gene-drug key from the Excel file we were sent. These versions are specifically stored in:
    [Versions]
    pointfinder_gene_drug_version = 032525
    resfinder_gene_drug_version = 032525

@emarinier

Copy link
Copy Markdown
Member Author

This looks really great Eric 😄. Thank you. I have one requested change (below) but have approved the overall PR.

Requested change

1. Could you update the version of the gene-drug keys from `032525` to `032525.1`? In the past, I had been adding a minor version number after the date so indicate we've modified the gene-drug key from the Excel file we were sent. These versions are specifically stored in: https://github.com/phac-nml/staramr/blob/472031fc630c1d75b10bc945b7abf2ecaeb224f6/staramr/databases/resistance/data/info.ini#L1-L3

Updated in 598ef25

Only the Resfinder gene-drug key was modified though, so I only updated that version.

@emarinier emarinier merged commit 77eb06e into development Jun 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants