1) Open the preferences in a tab instead of dialog for better UX. #6743#8832
Merged
akshay-joshi merged 2 commits intoJun 12, 2025
Merged
Conversation
4b87e6e to
22ff214
Compare
akshay-joshi
requested changes
Jun 9, 2025
akshay-joshi
left a comment
Contributor
There was a problem hiding this comment.
GUI Related Comments:
- When a workspace other than the default is selected, clicking the Settings button or selecting Preferences from the menu opens the Preferences tab in the default workspace. However, the active workspace does not switch accordingly.
- Open the Preferences tab, make some changes, and click Reset All Preferences. Then select Save & Reload Later. While the changes are correctly applied in the backend, they are not reflected in the currently open tab. A manual refresh or closing and reopening of the Preferences tab is needed to see the updates.
- In the Preferences tab, go to Browser → Display, change any one toggle setting, and click Save. The setting is saved successfully. However, after this, attempting to toggle any controls again (especially multiple times) will not work; the controls become unresponsive.
- Select the Browser node. You will see navigation links on the right side. Search for a string like "Layout", and click on any navigation link, it will fail, which is expected. Can we do something?
Source Code Related Comments:
- Please update the missing preferences in the "preferences.rst" file, as you have already updated the screenshots. A few preferences are missing from the documentation (not related to your PR, but it's good to have)
- Fix 5 old SonarQube code smells in Button.jsx if possible.
…dmin-org#6743 2) Add a search box to allow searching in the preferences tab. pgadmin-org#2864
9858bef to
c6f2098
Compare
Contributor
Author
Fixed.
Fixed.
Fixed.
I have changed logic to select the first item automatically if filter changes.
As discussed, it will be taken care in a separate ticket.
Fixed 3/5. Cognitive complexity didn't fix. |
c6f2098 to
70cf4a1
Compare
70cf4a1 to
85dbc3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.