Skip to content

1) Open the preferences in a tab instead of dialog for better UX. #6743#8832

Merged
akshay-joshi merged 2 commits into
pgadmin-org:masterfrom
adityatoshniwal:2867-pref-search
Jun 12, 2025
Merged

1) Open the preferences in a tab instead of dialog for better UX. #6743#8832
akshay-joshi merged 2 commits into
pgadmin-org:masterfrom
adityatoshniwal:2867-pref-search

Conversation

@adityatoshniwal

@adityatoshniwal adityatoshniwal commented Jun 5, 2025

Copy link
Copy Markdown
Contributor
  1. Add a search box to allow searching in the preferences tab. Add search box in preferenes (RM #4587) #2864

@adityatoshniwal adityatoshniwal force-pushed the 2867-pref-search branch 4 times, most recently from 4b87e6e to 22ff214 Compare June 6, 2025 09:53

@akshay-joshi akshay-joshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI Related Comments:

  1. When a workspace other than the default is selected, clicking the Settings button or selecting Preferences from the menu opens the Preferences tab in the default workspace. However, the active workspace does not switch accordingly.
  2. Open the Preferences tab, make some changes, and click Reset All Preferences. Then select Save & Reload Later. While the changes are correctly applied in the backend, they are not reflected in the currently open tab. A manual refresh or closing and reopening of the Preferences tab is needed to see the updates.
  3. In the Preferences tab, go to Browser → Display, change any one toggle setting, and click Save. The setting is saved successfully. However, after this, attempting to toggle any controls again (especially multiple times) will not work; the controls become unresponsive.
  4. Select the Browser node. You will see navigation links on the right side. Search for a string like "Layout", and click on any navigation link, it will fail, which is expected. Can we do something?

Source Code Related Comments:

  1. Please update the missing preferences in the "preferences.rst" file, as you have already updated the screenshots. A few preferences are missing from the documentation (not related to your PR, but it's good to have)
  2. Fix 5 old SonarQube code smells in Button.jsx if possible.

Comment thread docs/en_US/images/preferences_misc_user_interface.png
Comment thread web/pgadmin/static/js/PgTreeView/index.jsx
@adityatoshniwal

Copy link
Copy Markdown
Contributor Author

GUI Related Comments:

  1. When a workspace other than the default is selected, clicking the Settings button or selecting Preferences from the menu opens the Preferences tab in the default workspace. However, the active workspace does not switch accordingly.

Fixed.

  1. Open the Preferences tab, make some changes, and click Reset All Preferences. Then select Save & Reload Later. While the changes are correctly applied in the backend, they are not reflected in the currently open tab. A manual refresh or closing and reopening of the Preferences tab is needed to see the updates.

Fixed.

  1. In the Preferences tab, go to Browser → Display, change any one toggle setting, and click Save. The setting is saved successfully. However, after this, attempting to toggle any controls again (especially multiple times) will not work; the controls become unresponsive.

Fixed.

  1. Select the Browser node. You will see navigation links on the right side. Search for a string like "Layout", and click on any navigation link, it will fail, which is expected. Can we do something?

I have changed logic to select the first item automatically if filter changes.

Source Code Related Comments:

  1. Please update the missing preferences in the "preferences.rst" file, as you have already updated the screenshots. A few preferences are missing from the documentation (not related to your PR, but it's good to have)

As discussed, it will be taken care in a separate ticket.

  1. Fix 5 old SonarQube code smells in Button.jsx if possible.

Fixed 3/5. Cognitive complexity didn't fix.

@akshay-joshi akshay-joshi merged commit 1e0e9c4 into pgadmin-org:master Jun 12, 2025
32 checks passed
@adityatoshniwal adityatoshniwal deleted the 2867-pref-search branch September 17, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants