Propagate column renames to FK and unique constraints in the table dialog (#9060)

[dpage]

Summary

Fixes #9060.

In the Create Table dialog, renaming a column already propagated to the primary key definition, but foreign key and unique constraint definitions kept referencing the old column name — producing wrong/broken DDL.

Fix: mirror the existing PK rename-propagation logic in the foreign_key and unique_constraint depChange handlers — on a column name SET_VALUE in a new table, rewrite the old name to the new name in each FK's columns[].local_column and each unique constraint's columns[].column. Also added 'columns' to the unique constraint's deps so its depChange fires on column edits (FK already had it).

Changes

• table.ui.js (one file)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Create Table dialog now correctly propagates column renames to foreign key and unique constraint references so constraints reflect updated column names.

• Documentation

  • Release notes updated to document the bug fix.

• Tests

  • Added a test verifying rename propagation updates constraint references during table creation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3d838519-04f4-4da0-adff-33be92c0f389

📥 Commits

Reviewing files that changed from the base of the PR and between 0924f9c and 9a45a32.

📒 Files selected for processing (1)

• docs/en_US/release_notes_9_16.rst

✅ Files skipped from review due to trivial changes (1)

• docs/en_US/release_notes_9_16.rst

---

Walkthrough

This PR fixes a bug where renaming a column in the Create Table dialog failed to update references to that column within foreign key and unique constraint definitions by extending depChange handlers to propagate the new column name; tests and release notes were added.

Changes

Column Rename Propagation in Constraints

Layer / File(s)	Summary
Foreign Key and Unique Constraint depChange handlers web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.ui.js	Extended depChange logic to detect SCHEMA_STATE_ACTIONS.SET_VALUE on columns[*].name and remap dependent constraint references: foreign key local_column, unique constraint columns[*].column, and unique_constraint include entries. Handlers now receive source, topState, and actionObj.
Test coverage for column rename propagation web/regression/javascript/schema_ui_files/table.ui.spec.js	Added Jest test depChange column rename propagation verifying rename propagation for foreign key local columns, unique constraint columns, and unique_constraint INCLUDE lists in create-path scenarios.
Release notes documentation docs/en_US/release_notes_9_16.rst	Added Issue #9060 bullet under Version 9.16 Bug fixes documenting the Create Table fix where renaming a column updates constraint references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• pgadmin-org/pgadmin4#10042: Related changes around handling stale foreign_key.local_column when computing attnum to avoid ERD delete crashes; touches foreign key handling.

Suggested reviewers

• adityatoshniwal
• asheshv

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: propagating column renames to FK and unique constraints in the table dialog, with the issue reference.
Linked Issues check	✅ Passed	The pull request addresses all coding requirements from issue #9060: column renames now propagate to foreign key and unique constraint definitions in the Create Table dialog.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing issue #9060: the main logic fix in table.ui.js, release notes update, and comprehensive test coverage for the rename propagation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes column-rename propagation in the Create Table dialog so constraint definitions don’t keep referencing stale column names (Issue #9060), preventing incorrect/broken generated DDL.

Changes:

• Propagate renamed column names into foreign_key[].columns[].local_column when editing table columns in the Create Table dialog.
• Propagate renamed column names into unique_constraint[].columns[].column and ensure the unique-constraint handler is triggered on table column edits by adding columns to deps.
• Document the fix in the v9.16 release notes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/table.ui.js	Adds rename-propagation logic for FK + unique constraints when a table column name changes.
docs/en_US/release_notes_9_16.rst	Adds a bug-fix entry referencing Issue #9060.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[asheshv]

Approach is right and the new tests cover the headline cases. Two scope items worth addressing here rather than in a follow-up:

1. Exclusion constraints have an include list of bare column-name strings — same shape as the unique-constraint include you just fixed. The exclusion case isn't covered by the outer depChange, leaving it half-fixed for INCLUDE-clause constraints.
2. The outer columns mapping for FK and unique in table.ui.js is largely redundant — the inner depChange handlers in foreign_key.ui.js and unique_constraint.ui.js already update local_column / column in place in create-table mode. The net-new fix is really the unique include map (and would-be exclusion include). Worth trimming so the propagation isn't claimed in two places.