Skip to content

Let clicks pass through the object breadcrumbs popup (#9128)#10038

Merged
asheshv merged 2 commits into
pgadmin-org:masterfrom
dpage:fix-9128-breadcrumbs-clicks
Jun 12, 2026
Merged

Let clicks pass through the object breadcrumbs popup (#9128)#10038
asheshv merged 2 commits into
pgadmin-org:masterfrom
dpage:fix-9128-breadcrumbs-clicks

Conversation

@dpage

@dpage dpage commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #9128.

The object breadcrumbs popup is an absolutely-positioned overlay (position: absolute; bottom: 0; zIndex: 1004) at the bottom-left of the object explorer. Because it's purely informational, it shouldn't capture mouse input — but it did, blocking clicks on the tree items underneath it. Added pointer-events: none to the styled container so clicks pass through.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where the object breadcrumbs popup could block interactions with items in the object explorer beneath it.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dffd4825-d079-4f32-8537-e760b2d9c410

📥 Commits

Reviewing files that changed from the base of the PR and between 0752301 and d870a82.

📒 Files selected for processing (2)
  • docs/en_US/release_notes_9_16.rst
  • web/pgadmin/static/js/components/ObjectBreadcrumbs.jsx

Walkthrough

This pull request fixes a UI interaction issue in ObjectBreadcrumbs by adding pointerEvents: 'none' to prevent the popup from blocking mouse clicks on underlying tree items, and documents the fix in Version 9.16 release notes.

Changes

ObjectBreadcrumbs popup pointer-events fix

Layer / File(s) Summary
ObjectBreadcrumbs pointer-events styling
web/pgadmin/static/js/components/ObjectBreadcrumbs.jsx
StyledBox styling for ObjectBreadcrumbs is updated to set pointerEvents: 'none', allowing pointer events to pass through to underlying tree items instead of being blocked by the popup overlay.
Release notes documentation
docs/en_US/release_notes_9_16.rst
Version 9.16 release notes entry documents the ObjectBreadcrumbs popup fix for Issue #9128.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main code change: adding pointer-events handling to allow clicks to pass through the breadcrumbs popup, with the issue reference for context.
Linked Issues check ✅ Passed The PR directly addresses the primary coding requirement from issue #9128: adding pointer-events: none CSS to the ObjectBreadcrumbs component to prevent it from blocking clicks on underlying elements.
Out of Scope Changes check ✅ Passed The PR contains only the necessary pointer-events fix to ObjectBreadcrumbs plus documentation updates (release notes entries) directly related to this bug fix; no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dpage dpage force-pushed the fix-9128-breadcrumbs-clicks branch 2 times, most recently from 5e168b0 to 6669c8a Compare June 9, 2026 11:36
The breadcrumbs popup is an absolutely-positioned, informational overlay
at the bottom-left of the object explorer, so it intercepted pointer
events and blocked clicks on the tree items beneath it. Set
pointer-events: none so clicks pass through to the tree.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dpage dpage force-pushed the fix-9128-breadcrumbs-clicks branch from 6669c8a to 2c593e3 Compare June 9, 2026 11:37
@asheshv asheshv requested a review from Copilot June 10, 2026 14:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Object Breadcrumbs informational overlay so it no longer intercepts mouse clicks on underlying Object Explorer tree items (fix for #9128), and documents the fix in the 9.16 release notes.

Changes:

  • Set pointerEvents: 'none' on the ObjectBreadcrumbs popup container to allow click-through to tree items beneath.
  • Add a 9.16 release note entry referencing Issue #9128.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
web/pgadmin/static/js/components/ObjectBreadcrumbs.jsx Makes the breadcrumbs overlay non-interactive so it can’t block underlying clicks.
docs/en_US/release_notes_9_16.rst Adds a bug-fix release note entry for Issue #9128.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@asheshv asheshv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. pointer-events: none on the root is the right layer — the component has no interactive children so there's no risk of breaking clicks/focus inside.

Non-blocking suggestion: a one-line getComputedStyle(...).pointerEvents assertion in ObjectBreadcrumbs.spec.js would prevent a silent regression if the property gets dropped in a future restyle.

@asheshv asheshv merged commit 9939d33 into pgadmin-org:master Jun 12, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug with interaction of server list

3 participants