Let clicks pass through the object breadcrumbs popup (#9128)#10038
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis pull request fixes a UI interaction issue in ObjectBreadcrumbs by adding ChangesObjectBreadcrumbs popup pointer-events fix
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5e168b0 to
6669c8a
Compare
The breadcrumbs popup is an absolutely-positioned, informational overlay at the bottom-left of the object explorer, so it intercepted pointer events and blocked clicks on the tree items beneath it. Set pointer-events: none so clicks pass through to the tree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6669c8a to
2c593e3
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts the Object Breadcrumbs informational overlay so it no longer intercepts mouse clicks on underlying Object Explorer tree items (fix for #9128), and documents the fix in the 9.16 release notes.
Changes:
- Set
pointerEvents: 'none'on the ObjectBreadcrumbs popup container to allow click-through to tree items beneath. - Add a 9.16 release note entry referencing Issue #9128.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/pgadmin/static/js/components/ObjectBreadcrumbs.jsx | Makes the breadcrumbs overlay non-interactive so it can’t block underlying clicks. |
| docs/en_US/release_notes_9_16.rst | Adds a bug-fix release note entry for Issue #9128. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asheshv
left a comment
There was a problem hiding this comment.
LGTM. pointer-events: none on the root is the right layer — the component has no interactive children so there's no risk of breaking clicks/focus inside.
Non-blocking suggestion: a one-line getComputedStyle(...).pointerEvents assertion in ObjectBreadcrumbs.spec.js would prevent a silent regression if the property gets dropped in a future restyle.
Summary
Fixes #9128.
The object breadcrumbs popup is an absolutely-positioned overlay (
position: absolute; bottom: 0; zIndex: 1004) at the bottom-left of the object explorer. Because it's purely informational, it shouldn't capture mouse input — but it did, blocking clicks on the tree items underneath it. Addedpointer-events: noneto the styled container so clicks pass through.🤖 Generated with Claude Code
Summary by CodeRabbit