Skip to content

Fix double dot in generated font and image filenames (#9806)#10032

Merged
asheshv merged 2 commits into
pgadmin-org:masterfrom
dpage:fix-9806-font-double-dot
Jun 12, 2026
Merged

Fix double dot in generated font and image filenames (#9806)#10032
asheshv merged 2 commits into
pgadmin-org:masterfrom
dpage:fix-9806-font-double-dot

Conversation

@dpage

@dpage dpage commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #9806.

Webpack 5 asset modules include the leading dot in the [ext] token, so the img/[name].[ext] and fonts/[name].[ext] generator templates emit filenames with a double dot (e.g. Roboto-Bold..ttf, fa-solid-900..woff2). This switches both templates to [name][ext], which produces the correct single-dot filenames.

Changes

  • web/webpack.config.js: img/[name].[ext]img/[name][ext], fonts/[name].[ext]fonts/[name][ext]
  • Added release note (9.16).

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Fixed an issue where generated font and image filenames contained malformed formatting.
  • Documentation

    • Updated pgAdmin 4 v9.16 release notes with bug-fix details, PostgreSQL support versions 14–18, and bundled utilities information.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1dfdf99c-4218-4858-b9ea-1561e51175f5

📥 Commits

Reviewing files that changed from the base of the PR and between 00a8938 and 4f4d576.

📒 Files selected for processing (1)
  • docs/en_US/release_notes_9_16.rst

Walkthrough

The pull request fixes a bug where webpack was generating asset filenames with double dots (e.g., Roboto-Bold..ttf) by updating the webpack configuration patterns for images and fonts. The fix is documented in the v9.16 release notes.

Changes

Version 9.16 Release and Asset Filename Fix

Layer / File(s) Summary
Asset filename configuration fix
web/webpack.config.js
Webpack asset generator.filename patterns updated for images from img/[name].[ext] to img/[name][ext] and fonts from fonts/[name].[ext] to fonts/[name][ext], removing the hardcoded dot that caused double dots when filenames already end with a dot.
Version 9.16 release documentation
docs/en_US/release_notes_9_16.rst
Release notes updated with a bug-fix entry for Issue #9806 describing the double-dot filename issue in generated fonts and images.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Fix double dot in generated font and image filenames (#9806)' accurately summarizes the main change: updating webpack templates to remove double dots in asset filenames.
Linked Issues check ✅ Passed The PR successfully addresses issue #9806 by fixing webpack asset generator filename patterns to produce single-dot filenames instead of double-dot filenames in both image and font assets.
Out of Scope Changes check ✅ Passed All changes are within scope: webpack config fix for the core issue, release notes addition documenting the fix, and index update. No unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dpage dpage force-pushed the fix-9806-font-double-dot branch 2 times, most recently from 00a8938 to 7b5f269 Compare June 9, 2026 11:36
Webpack 5 asset modules include the leading dot in the [ext] token, so
the 'img/[name].[ext]' and 'fonts/[name].[ext]' templates produced
filenames with a double dot (e.g. Roboto-Bold..ttf). Use '[name][ext]'
so the emitted filenames are correct.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dpage dpage force-pushed the fix-9806-font-double-dot branch from 7b5f269 to 01c218a Compare June 9, 2026 11:37
@asheshv asheshv requested a review from Copilot June 10, 2026 14:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Webpack 5 asset-module filename templating to avoid double-dot filenames for generated images and fonts (addresses #9806), and documents the fix in the v9.16 release notes.

Changes:

  • Update Webpack asset generator.filename templates from [name].[ext] to [name][ext] for images and fonts.
  • Add a v9.16 release note entry referencing Issue #9806.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
web/webpack.config.js Adjusts asset-module filename templates to prevent double dots in emitted asset filenames.
docs/en_US/release_notes_9_16.rst Adds a bug-fix release note entry documenting the resolved double-dot asset filename issue.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@asheshv asheshv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Webpack 5's [ext] substitution token includes the leading dot, so [name].[ext] produced the .. doubling — [name][ext] is the canonical fix and matches what CopyPlugin at line 74 already does.

Generated artifacts in web/pgadmin/static/js/generated/ still carry the broken names in the repo but those regenerate via make bundle. Worth a quick CI check post-merge that the bundle output has clean single-dot filenames and no font 404s.

@asheshv asheshv merged commit 94564e4 into pgadmin-org:master Jun 12, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font files generated with double dots in filename (e.g. Roboto-Bold..ttf)

3 participants