Week 4 : maximal planar#573
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the planar “maximal planar” functionality by removing the unused biconnected-planar enum/dispatch and changing pgr_makeMaximalPlanar to handle disconnected graphs by processing each connected component independently.
Changes:
- Remove
BICONNECTEDPLANARfrom theWhichenum and related name mapping. - Update
Pgr_makeMaximalPlanar::makeMaximalPlanar()to split disconnected inputs into connected subgraphs and run maximal-planar generation per component. - Remove the previous “graph must be connected” exception from the internal generation routine.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/cpp_common/utilities.cpp |
Removes BICONNECTEDPLANAR name mapping from get_name(Which). |
include/planar/makeMaximalPlanar.hpp |
Implements per-connected-component processing for maximal planar generation and removes the prior connectivity exception. |
include/c_common/enums.h |
Removes BICONNECTEDPLANAR from the Which enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lean dispatcher Component splitting logic belongs in the algorithm layer (.hpp), not the shared driver. This ensures future planar algorithms (planarFaces, straightLineDrawing) that join the shared driver are not forced to inherit component-splitting behavior they may not want. Each algorithm decides its own disconnected-graph strategy.
Mohit242-bit
force-pushed
the
week4-maximal-planar
branch
from
65c4894 to
814a0c7
Compare
Week 4 PR creation
plan:
-maximal pgtap tests adding
-Disconnected components input logic