tests: pin the kept edge build and dependency byte for byte - #37
Conversation
The stale-edge prune test checked that 4.0.0.a1 and its dependency are still listed, but a publish that replaced either file with a different valid archive under the same name still passed. Capture both before the leftover is seeded and require identical bytes after the stable publish. Addresses CodeRabbit feedback on #36. Refs pfBlockerNG/pfBlockerNG#3390
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release test now records the existing edge package and dependency bytes before publishing and checks that both files remain byte-identical afterward. ChangesEdge package preservation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to No actionable merge risk remains; the new test checks byte preservation through the regeneration path. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each byte in place Comment |
Follow-up to #36, addressing CodeRabbit's nitpick there, which was missed before landing.
test_stable_build_prunes_a_stale_version_from_a_newer_family_edgechecked that edge still lists 4.0.0.a1 and carries its dependency. A publish that swapped either file for a different but valid archive under the same name still passed. The test now captures both files before the leftover 3.3.10 is seeded and requires identical bytes after the stable 3.3.11 publish.Verified by mutation: recompressing either kept file at a different zstd level inside the stale-destination branch of
publish()(valid archive, same contents, different bytes) passes every earlier assertion and fails the new byte check.Refs pfBlockerNG/pfBlockerNG#3390
Summary by CodeRabbit