tests: prove a stable publish leaves a newer-family edge alone - #35
Conversation
A stable 3.3.x release routes to stable, testing and edge. When edge already serves a newer family (4.0.0.a1), the publisher must update stable and testing only and leave the edge catalogue byte-identical, dependency included. The existing coverage exercised this with a testing-primary release only. Refs pfBlockerNG/pfBlockerNG#3390
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds a test for publishing a stable release to all channels when edge already contains a newer version. It checks that stable and testing update, while edge remains unchanged. ChangesRelease publishing test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The new test covers publishing stable 3.3.11 while edge has a newer release, including preserving edge files and dependency metadata. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the channels in a row Comment |
A stable 3.3.x release routes to stable, testing and edge. When edge already serves a newer release family (for example 4.0.0.a1), the publisher must update stable and testing and leave the edge catalogue byte-identical, including the dependency the edge build declares.
The existing
test_build_older_than_the_catalogues_newest_leaves_it_alonecovers this only for a testing-primary release (testing and edge). This adds the stable-primary case: stable and testing advance from 3.3.10 to 3.3.11, edge keeps 4.0.0.a1, and the report lists only stable and testing as touched.Test-only change. The test fails when the
staleguard inpublish()is disabled, including when the fan-out identity check is also bypassed (thetouchedassertion catches it).Refs pfBlockerNG/pfBlockerNG#3390
Summary by CodeRabbit