Skip to content

refactor: upgrade handlers #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneet2019 merged 2 commits into from
Oct 29, 2025
Merged

refactor: upgrade handlers #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f84a02c
refactor upgrade handlers
puneet2019 Oct 29, 2025
2169279
Merge branch 'main' into puneet/upgrade-handlers
puneet2019 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ import (
"github.com/persistenceOne/persistenceCore/v16/app/constants"
"github.com/persistenceOne/persistenceCore/v16/app/keepers"
"github.com/persistenceOne/persistenceCore/v16/app/upgrades"
v1500 "github.com/persistenceOne/persistenceCore/v16/app/upgrades/v15.0.0"
v1600rc0 "github.com/persistenceOne/persistenceCore/v16/app/upgrades/testnet/v16.0.0-rc0"
)

var (
DefaultNodeHome string
Upgrades = []upgrades.Upgrade{v1500.Upgrade}
Upgrades = []upgrades.Upgrade{v1600rc0.Upgrade}
ModuleBasics = module.NewBasicManager(keepers.AppModuleBasics...)
)

Expand Down
6 changes: 3 additions & 3 deletions app/upgrades/v15.0.0/constants.go → ...upgrades/testnet/v16.0.0-rc0/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package v15_0_0
package v16_0_0_rc0

import (
store "cosmossdk.io/store/types"
Expand All @@ -7,14 +7,14 @@ import (

const (
// UpgradeName defines the on-chain upgrade name.
UpgradeName = "v15.0.0"
UpgradeName = "v16.0.0-rc0"
)

var Upgrade = upgrades.Upgrade{
UpgradeName: UpgradeName,
CreateUpgradeHandler: CreateUpgradeHandler,
StoreUpgrades: store.StoreUpgrades{
Added: []string{},
Added: []string{}, //TODO protocol pool,
Deleted: []string{},
},
}
3 changes: 2 additions & 1 deletion app/upgrades/testnet/v15.0.0-rc0/upgrades.go → app/upgrades/testnet/v16.0.0-rc0/upgrades.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package v15_0_0_rc0
package v16_0_0_rc0

import (
"context"
Expand All @@ -13,6 +13,7 @@ func CreateUpgradeHandler(args upgrades.UpgradeHandlerArgs) upgradetypes.Upgrade
return func(ctx context.Context, plan upgradetypes.Plan, vm module.VersionMap) (module.VersionMap, error) {
sdkCtx := sdk.UnwrapSDKContext(ctx)
sdkCtx.Logger().Info("Running upgrade handler")

sdkCtx.Logger().Info("running module migrations...")
vm, err := args.ModuleManager.RunMigrations(sdkCtx, args.Configurator, vm)
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions ...upgrades/testnet/v15.0.0-rc0/constants.go → app/upgrades/v16.0.0/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package v15_0_0_rc0
package v16_0_0

import (
store "cosmossdk.io/store/types"
Expand All @@ -7,14 +7,14 @@ import (

const (
// UpgradeName defines the on-chain upgrade name.
UpgradeName = "v15.0.0-rc0"
UpgradeName = "v16.0.0"
)

var Upgrade = upgrades.Upgrade{
UpgradeName: UpgradeName,
CreateUpgradeHandler: CreateUpgradeHandler,
StoreUpgrades: store.StoreUpgrades{
Added: []string{},
Added: []string{}, //TODO add protocolpool
Deleted: []string{},
},
}
3 changes: 2 additions & 1 deletion app/upgrades/v15.0.0/upgrades.go → app/upgrades/v16.0.0/upgrades.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package v15_0_0
package v16_0_0

import (
"context"
Expand All @@ -13,6 +13,7 @@ func CreateUpgradeHandler(args upgrades.UpgradeHandlerArgs) upgradetypes.Upgrade
return func(ctx context.Context, plan upgradetypes.Plan, vm module.VersionMap) (module.VersionMap, error) {
sdkCtx := sdk.UnwrapSDKContext(ctx)
sdkCtx.Logger().Info("Running upgrade handler")

sdkCtx.Logger().Info("running module migrations...")
vm, err := args.ModuleManager.RunMigrations(sdkCtx, args.Configurator, vm)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions interchaintest/chain_upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const (
func TestPersistenceUpgradeBasic(t *testing.T) {
var (
chainName = "persistence"
initialVersion = "v14.0.1"
upgradeName = "v15.0.0"
initialVersion = "v15.0.0-rc1"
upgradeName = "v16.0.0-rc0"
upgradeRepo = PersistenceCoreImage.Repository
upgradeBranchVersion = PersistenceCoreImage.Version
)
Expand Down
Loading