QA fixups and convert Nvidia PMDA to extraunits#2634
Merged
Conversation
For power and temperature. + pmlogrewrite rules and qa for this + updated recipe for recreating qa/archives/nvidiagpu archive
Throughout the known (GNU) awk universe, this works:
awk 'END { f = "/foo"; print >"/tmp" f }' </dev/null
but on macOS this produces a "awk: syntax error"
However, this works for all versions of awk:
awk 'END { f = "/foo"; print >("/tmp" f) }' </dev/null
modified: qa/1633
modified: qa/1674
modified: qa/671
modified: qa/681
modified: qa/new
modified: qa/new-dup
modified: qa/new-grind
modified: qa/src/mv-me
modified: src/ctl-tools/ctl-tools.sh
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds explicit temperature and power unit metadata to the NVIDIA PMDA, introduces pmlogrewrite support and QA coverage for NVIDIA archives, updates archive generation, and adjusts several AWK print-redirection expressions in QA and tool scripts. ChangesNVIDIA PMDA unit metadata and pmlogrewrite support
AWK print redirection parenthesization fixes
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@qa/1675`:
- Line 57: The archive iteration currently uses a literal glob fallback, which
can cause a bogus loop entry when no matching files exist. Update the loop in
the archive-handling logic to use the same unmatched-safe listing approach used
in related QA fixes, replacing the echo-based expansion with the ls-based
pattern so the loop only runs for real nvidiagpu archive indexes. Locate the
change in the archive iteration expression and keep the surrounding sed-based
suffix stripping intact.
In `@qa/group`:
- Line 2225: The group association for test 1675 is missing the local tag, so
update the test entry in the qa/group definition to include local alongside the
existing pmlogrewrite and pmda.nvidia tags. Keep the change scoped to the test
1675 association so it participates in expected local-group runs.
In `@src/pmdas/nvidia/rewrite.conf`:
- Around line 9-11: The nvidia.power rewrite rule is using the wrong scale
metadata and no longer matches the PMDA descriptor. Update the metric stanza for
nvidia.power in rewrite.conf so its extraunits uses the same power scale as the
PMDA metadata (PM_POWER_mW) rather than POWER,W, keeping the rewrite contract
consistent with the live descriptor.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: baadc2b3-9421-4a2a-b639-bff4a59f1731
⛔ Files ignored due to path filters (3)
qa/1559.outis excluded by!**/*.outqa/1670.outis excluded by!**/*.outqa/1675.outis excluded by!**/*.out
📒 Files selected for processing (16)
qa/1559qa/1633qa/1674qa/1675qa/671qa/681qa/archives/mk.nvidiagpuqa/groupqa/newqa/new-dupqa/new-grindqa/src/mv-mesrc/ctl-tools/ctl-tools.shsrc/pmdas/nvidia/GNUmakefilesrc/pmdas/nvidia/nvidia.csrc/pmdas/nvidia/rewrite.conf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.