fix[BISERVER-15545]: enhance doSetMetadata to handle invalid or unparseable XML payloads (#6251)#6255
Conversation
…seable XML payloads (#6251)
There was a problem hiding this comment.
Pull request overview
This PR updates the XML metadata update endpoint to classify missing or unparseable XML payloads as unsupported media type responses instead of server errors.
Changes:
- Adds 415 handling for missing/null XML payloads and XML unmarshalling/parsing failures.
- Extracts XML unmarshalling and stream-closing logic into helper methods.
- Updates the XXE metadata test expectation from 500 to 415.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
extensions/src/main/java/org/pentaho/platform/web/http/api/resources/FileResource.java |
Adds XML payload validation/error handling and updates REST status documentation. |
extensions/src/test/java/org/pentaho/platform/web/http/api/resources/FileResourceTest.java |
Updates the XXE metadata test to expect HTTP 415. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ( metadataXml == null ) { | ||
| return Response.status( Response.Status.UNSUPPORTED_MEDIA_TYPE ).entity( "Missing XML payload." ).build(); |
|
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
✅ Build finished in 41m 6sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl extensions👌 All tests passed! Tests run: 1656, Failures: 0, Skipped: 5 Test Results ℹ️ This is an automatic message |
original PR: #6251
@pentaho/tatooine_dev