[BACKLOG-48506] - refactor file extension filter to be reusable#6252
Closed
abryant-hv wants to merge 1 commit into
Closed
[BACKLOG-48506] - refactor file extension filter to be reusable#6252abryant-hv wants to merge 1 commit into
abryant-hv wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a new Spring configuration file that externalizes the list of VFS-filtered file extensions into a reusable util:set bean, and wires it into the main Pentaho Spring context.
Changes:
- Adds
vfs-filtered-extensions.spring.xmldefining avfsFilteredExtensionsset with extensions such ashtml,pdf,rtf,ktr,kjb,prpt,xanalyzer, etc. - Imports the new file from
pentaho-spring-beans.xmlso the bean is available in the application context.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| assemblies/pentaho-solutions/src/main/resources/pentaho-solutions/system/vfs-filtered-extensions.spring.xml | New Spring config exposing a reusable vfsFilteredExtensions set. |
| assemblies/pentaho-solutions/src/main/resources/pentaho-solutions/system/pentaho-spring-beans.xml | Imports the new vfs-filtered-extensions.spring.xml into the central context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+21
| xmlns:util="http://www.springframework.org/schema/util" | ||
| xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd | ||
| http://www.springframework.org/schema/util http://www.springframework.org/schema/util/spring-util.xsd" | ||
| default-lazy-init="true"> | ||
|
|
||
| <util:set id="vfsFilteredExtensions"> | ||
| <value>html</value> | ||
| <value>pdf</value> | ||
| <value>rtf</value> | ||
| <value>txt</value> | ||
| <value>xlsx</value> | ||
| <value>ktr</value> | ||
| <value>kjb</value> | ||
| <value>prpt</value> | ||
| <value>prpti</value> | ||
| <value>xanalyzer</value> | ||
| <value>properties</value> | ||
| </util:set> |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage
Collaborator
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
Collaborator
✅ Build finished in 9m 3sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
assemblies/pentaho-solutions❗ No tests found!ℹ️ This is an automatic message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.