Skip to content

fix[BACKLOG-50150]: fix testDoIsParameterizableError unit test#6248

Merged
joana-fb merged 1 commit into
masterfrom
BACKLOG-50150
May 25, 2026
Merged

fix[BACKLOG-50150]: fix testDoIsParameterizableError unit test#6248
joana-fb merged 1 commit into
masterfrom
BACKLOG-50150

Conversation

@joana-fb

Copy link
Copy Markdown
Contributor

@pentaho/tatooine_dev

@joana-fb joana-fb requested a review from a team as a code owner May 25, 2026 15:25
Copilot AI review requested due to automatic review settings May 25, 2026 15:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a failing unit test in FileResourceTest by correcting the expected number of invocations of NoSuchBeanDefinitionException#getMessage() in testDoIsParameterizableError() to match the current FileResource#doIsParameterizable implementation.

Changes:

  • Update Mockito verification to expect getMessage() to be called once (instead of three times) in the error-path test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hitachivantarasonarqube

Copy link
Copy Markdown

@buildguy

Copy link
Copy Markdown
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy

Copy link
Copy Markdown
Collaborator

✅ Build finished in 40m 19s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl extensions

👌 All tests passed!

Tests run: 1819, Failures: 0, Skipped: 1    Test Results


ℹ️ This is an automatic message

@joana-fb joana-fb merged commit 91db6b1 into master May 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants