[BACKLOG-49619][BACKLOG-48608] feat: add broker-based oauth client support#10521
Draft
AAravind27 wants to merge 1 commit into
Draft
[BACKLOG-49619][BACKLOG-48608] feat: add broker-based oauth client support#10521AAravind27 wants to merge 1 commit into
AAravind27 wants to merge 1 commit into
Conversation
Collaborator
❌ Build failed in 1m 27sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
engine,plugins/pur/core,plugins/repositories/core,ui❗ No tests found!Errors:Filtered log (click to expand)
ℹ️ This is an automatic message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: https://github.com/pentaho/pentaho-plugin-oauth-ee/pull/2
This pull request introduces significant enhancements to support advanced OAuth 2.0 authentication flows and adds a robust, user-friendly CLI configuration management system. The main changes include new OAuth-related parameters, a new configuration manager, and a CLI command handler for managing configuration settings.
Authentication and OAuth 2.0 Enhancements:
IParamsandParams(browserAuth,deviceCode,preferredIdp,serviceAccount) to support OAuth 2.0 browser-based, device code, and service account authentication flows. These parameters are exposed via getters/setters and the builder pattern, allowing flexible configuration of authentication methods. [1] [2] [3] [4] [5]pentaho-oauth-clientinpom.xmlto enable OAuth 2.0 client functionality.CLI Configuration Management:
CliConfigclass responsible for secure storage and retrieval of CLI configuration settings (e.g., authentication timeouts, token store backend, preferred IdP). Supports loading, saving, updating, and resetting configuration properties, with validation and sensible defaults.CliConfigCommandHandler, enabling users to manage CLI configuration via commands similar tonpm configorgit config(e.g.,-config:set,-config:get,-config:list,-config:reset). This handler provides clear usage instructions and validation for supported configuration keys.