feat(VerticalNavigation): update to latest PD specs#5182
Open
plagoa wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates HvVerticalNavigation to align with the latest Product Design specs. It introduces a new HvVerticalNavigationSection component, adds optional search functionality to the navigation tree, lifts open and selected state into the parent (with onOpenChange / onSelectedChange callbacks shared via context), and reworks several styles (group wrapper with grid-row transitions, level padding via CSS variables, theme tweaks for Pentaho, etc.).
Changes:
- New
HvVerticalNavigationSection(with "See All / See Less" affordance) and updatedindex.tsexports. HvVerticalNavigationnow propagatesopen/selectedplus setters via context;HvVerticalNavigationTreegains asearchprop with collapsed/expanded UX.- Style refactor of
VerticalNavigation/TreeViewItem(sibling separators with* + *,groupWrappergrid animation, level padding via CSS variables) and Pentaho theme adjustments.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/VerticalNavigation/VerticalNavigation.tsx | Adds onOpenChange, selected, defaultSelected, onSelectedChange; mirrors props into local state and exposes setters via context. |
| packages/core/src/VerticalNavigation/VerticalNavigationContext.tsx | Adds setOpen, selected, setSelected to the context value. |
| packages/core/src/VerticalNavigation/VerticalNavigation.styles.tsx | Replaces :not(nav:first-of-type) selectors with * + * and simplifies first/collapsed paddings. |
| packages/core/src/VerticalNavigation/Navigation/Navigation.tsx | Adds search prop (input when open, icon button when collapsed), filtered leaves view, and integrates context-driven selection. |
| packages/core/src/VerticalNavigation/Navigation/Navigation.styles.tsx | Adds searchContainer, searchIcon, noResults styles. |
| packages/core/src/VerticalNavigation/NavigationPopup/NavigationPopupContainer.tsx | Wires useDefaultProps("HvVerticalNavigationPopup", …) for theme overrides. |
| packages/core/src/VerticalNavigation/Section/NavigationSection.tsx | New section component with mouse-enter popup and "See All/Less" pagination. |
| packages/core/src/VerticalNavigation/Section/NavigationSection.styles.tsx | Styles for the new section. |
| packages/core/src/VerticalNavigation/Section/index.ts | Re-exports the new section. |
| packages/core/src/VerticalNavigation/TreeView/TreeViewItem.tsx | Wraps icons in HvIconContainer, adds groupWrapper, exposes level padding via CSS var, repositions caret. |
| packages/core/src/VerticalNavigation/TreeView/TreeViewItem.styles.tsx | Adds groupWrapper grid-rows transition and gap/icon spacing changes. |
| packages/core/src/VerticalNavigation/index.ts | Exports the new Section and NavigationPopup modules. |
| packages/core/src/themes/pentaho.ts | Theme adjustments for new structure (* + * separators, popup container variable, expandable font weight, group offsets). |
| apps/docs/src/content/components/vertical-navigation.mdx | Adds a docs example demonstrating sections + search. |
5e85037 to
f6615f4
Compare
f6615f4 to
64b1227
Compare
679bc7a to
3e4432a
Compare
3e4432a to
3d309d8
Compare
3d309d8 to
1982839
Compare
1982839 to
ff8758b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.