feat(Badge): add new color variants#5178
Merged
Merged
Conversation
plagoa
commented
May 26, 2026
plagoa
commented
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new semantic color variants to HvBadge styling for the Pentaho theme and documents them in Storybook and the docs site.
Changes:
- Added Pentaho theme styles for
HvBadgewhencolorispositive,warning, ornegative. - Updated the Badge Storybook “Test” story to showcase the new variants.
- Updated Badge documentation examples to include
warningandnegative(and minor formatting cleanup).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/themes/pentaho.ts | Adds positive/warning/negative badge color styling (text + dimmed background) for non-empty badges. |
| packages/core/src/Badge/Badge.stories.tsx | Extends the visual test story with the new badge color variants. |
| apps/docs/src/content/components/badge.mdx | Updates docs examples to demonstrate the new badge colors and simplifies componentProps formatting. |
zettca
approved these changes
May 26, 2026
| backgroundColor: theme.colors.primaryDimmed, | ||
| }, | ||
| ...Object.fromEntries( | ||
| (["primary", "positive", "warning", "negative"] as const).map( |
Member
There was a problem hiding this comment.
can we leverage semaColors, aligning this with HvAvatar?
we can keep info undocumented if you think it's better
Suggested change
| (["primary", "positive", "warning", "negative"] as const).map( | |
| (["primary", ...semaColors]).map( |
francisco-guilherme
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.