Backport [PATCH] Let's move some stuff#3
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR backports changes by updating runtime API decoding logic and introducing a constant for maximum extrinsic depth. Key changes include:
- Replacing a decode function call in the proc-macro API implementation.
- Introducing and using a new constant MAX_EXTRINSIC_DEPTH in the executive runtime.
- Updating the method of obtaining the encoded extrinsic length in transaction validation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| substrate/primitives/api/proc-macro/src/impl_runtime_apis.rs | Replaces decode_all_with_depth_limit with a direct call to decode in the generated code. |
| substrate/frame/executive/src/lib.rs | Adds a MAX_EXTRINSIC_DEPTH constant and updates decoding/encoding logic for extrinsics. |
Comments suppressed due to low confidence (2)
substrate/primitives/api/proc-macro/src/impl_runtime_apis.rs:106
- The change from using decode_all_with_depth_limit with MAX_EXTRINSIC_DEPTH to using decode without a depth limit removes an important safety check. Confirm that equivalent depth protection is implemented elsewhere.
match #c::Decode::decode(
substrate/frame/executive/src/lib.rs:718
- [nitpick] Replacing the using_encoded closure with a full uxt.encode() may introduce additional memory allocation. Verify that this change does not negatively impact performance in high-throughput scenarios.
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
f682d1a