Cache PR check worflow#347
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the workflow by introducing a concurrency block and splitting the validation steps into separate jobs for formatting and testing/clippy checks. Key changes include:
- Adding a concurrency configuration to cancel in-progress workflow runs.
- Introducing a dedicated job for running "cargo fmt --check" inside a Rust container.
- Adding a job for running tests and clippy with caching and a permission fix.
Comments suppressed due to low confidence (1)
.github/workflows/pr-check.yml:15
- [nitpick] The job name 'fmt' is very terse; consider renaming it to something like 'format-check' to improve clarity.
fmt:
sfffaaa
approved these changes
Jun 2, 2025
sfffaaa
reviewed
Jun 2, 2025
| fmt: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: rust:1.87-slim |
Contributor
There was a problem hiding this comment.
Does that mean if we change the rusttoolchain file, we also need to change here?
Contributor
Author
There was a problem hiding this comment.
Normally no this is just for format check that's why i used the latest and slim version of the container.
neutrinoks
reviewed
Jun 3, 2025
neutrinoks
reviewed
Jun 3, 2025
neutrinoks
approved these changes
Jun 3, 2025
neutrinoks
left a comment
neutrinoks
left a comment
Contributor
There was a problem hiding this comment.
Looks good 🚀 I've left some comments for optional processing...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.