Test enhancement#1
Open
peter279k wants to merge 1 commit into
Open
Conversation
peter279k
commented
Jul 1, 2020
| $this->assertEquals($validity, $result, sprintf('Tested plate: \'%s\', should be %s', $plate, (bool)$validity)); | ||
| } | ||
|
|
||
| $this->assertGreaterThanOrEqual(0, count($validationResults)); |
Author
There was a problem hiding this comment.
On some test cases, $validationResults will be empty array and it will present This test did not perform any assertions during PHPUnit tests running.
To fix this issue, it should add this line to let all results can assert length is greater than or equal to 0.
peter279k
commented
Jul 1, 2020
| $this->assertEquals($type, $result, sprintf('Tested plate: \'%s\', should be %s', $plate, $type)); | ||
| } | ||
|
|
||
| $this->assertGreaterThanOrEqual(0, count($typeResults)); |
Author
There was a problem hiding this comment.
On some test cases, $typeResults will be empty array and it will present This test did not perform any assertions during PHPUnit tests running.
To fix this issue, it should add this line to let all results can assert length is greater than or equal to 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed log
php-5.6,php-7.0andphp-7.1versions are going to be inactive. Using thephp-7.2version for this package at least.PHPUnit\Framework\TestCasenamespace for upgrading PHPUnit8.xversion.composer updatecommand.use, but not used.