Conversation
- Use item.href on link items (falling back to #) instead of hardcoded # - Extract logInvalidType helper in v2/validateStyle.js to match v5 pattern - Revert unscoped cosmetic rename in src/server/validateStyle.js (v5 file) - Add tests for link href behaviour and validateStyle type-mismatch path
- Use CONST_CASE block types (TEXT, IMAGE, LINK) matching actual v2 API - Render LINK blocks as span with data-iframe-url/data-embeddable, not anchor - Default validateStyle layout to 'text' via nullish coalescing - Update script mocks and test fixtures to match real v2 API response shape
- Make styles a function accepting fontSize so style.text.size is rendered correctly - Fix textColor to read style.color for flex layout instead of style.text.color - Switch action link CSS selectors from a to [data-iframe-url] to match SSR markup - Use Number() instead of unary + for ratio string coercion
style.text.fontFamily and style.text.align were hardcoded in the SSR output, causing accepted text style options to have no effect on the rendered message.
feat(DTCRCMERC-5257): add renderV2Message SSR module
sailaya99
requested review from
jeremy-herman,
perco12,
surekhaw and
yeul
as code owners
JordanClemons
approved these changes
Jun 4, 2026
|
🎉 This PR is included in version 1.86.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cutting the next paypal-messaging-components release from develop to release.
Included changes:
Validation: