fix: AT modal amount formatting#1323
Open
jayasd12 wants to merge 2 commits into
Open
Conversation
jayasd12
requested review from
jeremy-herman,
perco12,
surekhaw and
yeul
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem fixed: In Austrian (AT) modals, the amount displayed in the offer accordion used a
different thousands-separator format than the calculator input field. The EUR currency format in
de-AT uses a period as the thousands separator, while the number format uses a narrow no-break
space — causing a visual mismatch.
As a temporary fix, used localize lib for AT to re-format as number style instead of currency.
Screenshots / Videos
Testing instructions
https://www.te-upstream-at-expansion.qa.paypal.com/credit-presentment/lander/modal?customer_id=YSG9BQ5DWPD5E&offer=PAY_LATER_LONG_TERM&stageTag=atmodalformatting001&channel=PAY_LATER_HUB
stageTag - atmodalformatting001
Review
The expected SLA for reviews in this repo is days.
All pull requests require an initial review from your team followed by code owner approval.
While initial review is ongoing, please add the following label to your PR
Needs initial review. This initial review process should ensure that:Once you have received initial approval, please do the following:
Needs initial reviewNeeds codeowner reviewCode owners will then review the PR in accordance with our SLA. This process helps maintain code quality and reduces review cycles.