refactor: update messaging logos#1303
Open
yeul wants to merge 10 commits into
Open
Conversation
yeul
added
snapshots
yeul
added
Needs initial review
and removed
snapshots
surekhaw
approved these changes
May 7, 2026
perco12
reviewed
May 11, 2026
| 'default', | ||
| { | ||
| logo: Logo.PP_PAYPAL.WHITE, | ||
| logo: Logo.WORDMARK.WHITE, |
Contributor
There was a problem hiding this comment.
is the logo WORDMARK from the sdk team? As I know we using the term BADGE for v6. I wonder if that apply for v5
Collaborator
Author
There was a problem hiding this comment.
yeah it comes from the sdk logos package. the actual logo names a user passes through are the same as usual - primary, alternative, inline, none. this just changes the underlying logo to match.
perco12
reviewed
May 11, 2026
Contributor
There was a problem hiding this comment.
Just leaving it on any inline snapshot but the inline logos seem to be slightly larger than the text. Can we look at getting them at the same size
perco12
approved these changes
May 20, 2026
yeul
added
the
DO NOT MERGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates logos to v5 across all supported regions.
Screenshots / Videos
Testing instructions
Review
The expected SLA for reviews in this repo is days.
All pull requests require an initial review from your team followed by code owner approval.
While initial review is ongoing, please add the following label to your PR
Needs initial review. This initial review process should ensure that:Once you have received initial approval, please do the following:
Needs initial reviewNeeds codeowner reviewCode owners will then review the PR in accordance with our SLA. This process helps maintain code quality and reduces review cycles.