Skip to content

feat: add upstream message examples#49

Merged
nbierdeman merged 6 commits into
paypal-examples:mainfrom
merlinpaypal:upstream-message-examples
Jun 16, 2025
Merged

feat: add upstream message examples#49
nbierdeman merged 6 commits into
paypal-examples:mainfrom
merlinpaypal:upstream-message-examples

Conversation

@merlinpaypal

Copy link
Copy Markdown
Contributor

No description provided.

@merlinpaypal
merlinpaypal requested a review from a team as a code owner June 10, 2025 12:24
Comment thread client/upstreamMessages/html/src/minimal/app.js Outdated
Comment thread client/upstreamMessages/html/src/recommended/app.js Outdated

@EvanReinstein EvanReinstein left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! A few comments re: clientToken and leveraging the component loader.

Comment thread client/upstreamMessages/html/src/minimal/app.js Outdated
Comment thread client/upstreamMessages/html/src/minimal/index.html Outdated
Comment thread client/upstreamMessages/html/src/recommended/app.js Outdated
Comment thread client/upstreamMessages/html/src/recommended/index.html Outdated
@merlinpaypal
merlinpaypal force-pushed the upstream-message-examples branch from d153a95 to a49b694 Compare June 10, 2025 16:49
@nbierdeman

Copy link
Copy Markdown
Contributor

@merlinpaypal, looking good! Do you mind rebasing and moving upstreamMessages into /client/components/?

@merlinpaypal

Copy link
Copy Markdown
Contributor Author

@nbierdeman pushed up the moving of the folder

Comment thread client/components/upstreamMessages/html/src/minimal/app.js
Comment thread client/components/upstreamMessages/html/src/index.html
Comment thread client/components/upstreamMessages/html/src/recommended/index.html Outdated
@nbierdeman

Copy link
Copy Markdown
Contributor

@merlinpaypal, looks like prettier's complaining about some formatting, but hopefully will be good to merge after that. 👍

Comment thread client/components/upstreamMessages/html/src/recommended/app.js Outdated
Comment thread client/components/upstreamMessages/html/src/recommended/app.js Outdated
Comment thread client/components/upstreamMessages/html/src/recommended/app.js
Comment thread client/components/upstreamMessages/html/README.md Outdated
@merlinpaypal

Copy link
Copy Markdown
Contributor Author

@nbierdeman my team has approved these changes, so it's ready to merge whenever you approve it and want to merge it as well

@nbierdeman nbierdeman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @merlinpaypal! 🤘

@dwilliams27 dwilliams27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nbierdeman
nbierdeman merged commit aad2d16 into paypal-examples:main Jun 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants