Honeywell Scanner: Overview Screen Action Selection#971
Open
jhbruhn wants to merge 2 commits into
Open
Conversation
…which launches Consume/Purchase/Transfer/Inventory fragment via Dialog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Dialog when a Barcode is scanned using a Honeywell scanner while the OverviewStartFragment is active, giving the user an option on how to process the barcode.
Please let me know whether the fragment argument usage here is correct. It works for me, but it has been quite a while since I developed for Android and back then everything was slightly different :D
IMO it would also be nice if this dialog had the icons in there, but that does not seem to be possible with the chosen implementation. It would need a new view definition, probably a bottomsheet would be coherent here?