Repository navigation
fix: run StarRocks statements through Flight SQL Execute - #153
Merged
Merged
Conversation
StarRocks does not implement DoPut/acceptPutStatement, so ExecuteUpdate never reaches the SQL engine.
prasadlohakpure
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Execute(GetFlightInfo/DoGet), including DML and DDL whenreturn_resultis false.ExecuteUpdate(DoPut/acceptPutStatement), so those statements previously failed before the SQL ran.return_resultis false, the result stream is still consumed and the job result is a singlestatement executedmessage.Test plan
INSERT/UPDATE/DDL job withreturn_result: falseand confirm it no longer fails withacceptPutStatement unimplemented.return_result: trueand confirm the result rows are still returned.SELECTwithreturn_result: trueand confirm existing result collection is unchanged.