Repository navigation
feat(web): address post-release UI feedback and fix mobile layout - #152
Merged
prasadlohakpure merged 3 commits intoOct 16, 2026
Conversation
gauravwarale
commented
Oct 15, 2026
gauravwarale
commented
Contributor
- fix avatar initials for email usernames ("jane.doe@pattern.com" no longer yields "JC"); strip the domain before deriving initials
- replace table row click with a "View" Button asChild + Link in a trailing actions column; pin the last column, and the first on >=768px
- fix nested hydration error in the mobile nav drawer avatar
- job/cluster/command detail: weak "API response" button that opens a modal CodeBlock instead of a new tab; section headers keep their tint with no hover state
- job detail header: icon-only buttons below 640px so the title no longer collapses; add Name to the Overview
- filter drawers: drop the close button (tap outside / swipe to dismiss)
- fix avatar initials for email usernames ("jane.doe@pattern.com" no
longer yields "JC"); strip the domain before deriving initials
- replace table row click with a "View" Button asChild + Link in a
trailing actions column; pin the last column, and the first on >=768px
- fix nested <button> hydration error in the mobile nav drawer avatar
- job/cluster/command detail: weak "API response" button that opens a
modal CodeBlock instead of a new tab; section headers keep their tint
with no hover state
- job detail header: icon-only buttons below 640px so the title no
longer collapses; add Name to the Overview
- filter drawers: drop the close button (tap outside / swipe to dismiss)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Responsive layouts, hydration, and shared modal/drawer interactions still need browser verification before approval.
0 open findings
What changed in this PR
Addresses post-release feedback across the web app’s job, command, and cluster pages, focusing on mobile layouts and consistent navigation.
Changes:
- Replaces clickable table rows with explicit View links and responsive pinned columns.
- Adds API-response modals, consistent detail sections, and compact mobile header actions.
- Corrects avatar initials and nested-button markup; simplifies filter drawers.
| File | Description |
|---|---|
| web/src/modules/Jobs/Jobs.tsx | Removes row-click navigation. |
| web/src/modules/Jobs/JobDetails/JobInformationPane.tsx | Adopts shared sections and adds Name. |
| web/src/modules/Jobs/JobDetails/JobDetails.tsx | Uses API-response modal. |
| web/src/modules/Jobs/JobDetails/CancelJobButton.tsx | Makes mobile cancel action icon-only. |
| web/src/modules/Jobs/Helper.tsx | Adds job View actions. |
| web/src/modules/Commands/Helper.tsx | Adds command View actions. |
| web/src/modules/Commands/Commands.tsx | Removes row-click navigation. |
| web/src/modules/Commands/CommandDetails/CommandInformationPane.tsx | Adopts shared detail sections. |
| web/src/modules/Commands/CommandDetails/CommandDetails.tsx | Uses API-response modal. |
| web/src/modules/Clusters/Helper.tsx | Adds cluster View actions. |
| web/src/modules/Clusters/ClustersDetails/ClustersDetails.tsx | Uses API-response modal. |
| web/src/modules/Clusters/ClustersDetails/ClusterInformationPane.tsx | Adopts shared detail sections. |
| web/src/modules/Clusters/Clusters.tsx | Removes row-click navigation. |
| web/src/components/ListPage/RowLink.tsx | Removes superseded primary-cell link. |
| web/src/components/ListPage/RowActionButton.tsx | Adds reusable View link button. |
| web/src/components/ListPage/ListPage.tsx | Centralizes responsive column pinning. |
| web/src/components/FilterMenu/FilterMenu.tsx | Removes drawer close buttons. |
| web/src/components/ExternalLinkButton/ExternalLinkButton.tsx | Removes superseded external-link button. |
| web/src/components/DetailPage/DetailSection.tsx | Adds consistent tinted section headers. |
| web/src/components/AppShell/HeimdallShell.tsx | Fixes initials and mobile avatar markup. |
| web/src/components/ApiResponseButton/ApiResponseButton.tsx | Fetches and displays JSON in a modal. |
| web/src/common/hooks/useIsSmUp.ts | Adds shared responsive breakpoint hook. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
prasadlohakpure
previously approved these changes
Oct 15, 2026
prasadlohakpure
approved these changes
Oct 15, 2026
…ck-fixes-avatar-tables-detail-pages-mobile
prasadlohakpure
deleted the
CU-86e3qr435_Heimdall-UI-post-release-feedback-fixes-avatar-tables-detail-pages-mobile
branch
October 16, 2026 05:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.