You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bumps aurora to round scissor and EFB copy rects with the rasterizer's pixel-center rule (patchzyy/aurora-wiicompiled#9), so a copy clear no longer leaves a one-pixel black column next to the quad that redraws it at non-integer render scales.
Updated an internal component reference. The available change details do not indicate any changes to app features or behavior, so no user-facing impact can be confirmed.
No actionable comments were generated in the recent review.
Walkthrough
The aurora-main submodule pointer changes from commit 33067e34a17ca680eb961d9e0f3d48ddb22a7d7f to ac35787a014ddb1c7364aae151a7430f1f8bb2a5. The submodule contents are not shown.
Changes: Aurora submodule update
Layer / File(s)
Summary
Update submodule reference aurora-main
The submodule pointer now references commit ac35787a014ddb1c7364aae151a7430f1f8bb2a5.
This updates the bundled Aurora graphics library so scissor and copy rectangles are rounded consistently, which is meant to remove the black line near the minimap. No concrete merge-blocking risk was found, though the visual fix itself has not been confirmed in a race.
Pre-merge checks: 3 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Linked Issues check
Issue #397 requires a fix for a black vertical line near the minimap during races. The PR changes only the aurora-main submodule reference, from 33067e34a17ca680eb961d9e0f3d48ddb22a7d7f to ac35787a014…
Provide evidence that commit ac35787a014ddb1c7364aae151a7430f1f8bb2a5 in aurora-wiicompiled contains the scissor and EFB copy rounding change from patchzyy/aurora-wiicompiled#9. Relevant evidence includes the diff of that commit or a test s…
Passed checks: 3 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Fix black line next to the minimap" matches the main change. The PR objectives say the change rounds scissor and EFB copy rectangles to stop a one-pixel black column beside the minimap at n…
Out of Scope Changes check
The only change in this PR is the aurora-main submodule pointer update, shown as +1/-1 with no declaration changes. The PR description states that this bump delivers the Aurora rounding fix for #397. …
Full details: Title check
Explanation
The title "Fix black line next to the minimap" matches the main change. The PR objectives say the change rounds scissor and EFB copy rectangles to stop a one-pixel black column beside the minimap at non-integer render scales. The title names the symptom and the affected area, but not the mechanism. The only file change is a submodule pointer bump to aurora-main, so the title describes the intent of the change, which the objectives support.
Full details: Out of Scope Changes check
Explanation
The only change in this PR is the aurora-main submodule pointer update, shown as +1/-1 with no declaration changes. The PR description states that this bump delivers the Aurora rounding fix for #397. The change connects directly to the linked issue scope. No unrelated changes are present.
Full details: Linked Issues check
Explanation
Issue #397 requires a fix for a black vertical line near the minimap during races. The PR changes only the aurora-main submodule reference, from 33067e34a17ca680eb961d9e0f3d48ddb22a7d7f to ac35787a014ddb1c7364aae151a7430f1f8bb2a5. The PR description states that the fix rounds scissor and EFB copy rectangles in aurora-wiicompiled#9. The submodule contents are not in the reviewed repository tree, so the rounding change cannot be read here. The PR adds no coding change or automated test in this repository for the minimap glitch. Whether the pinned submodule commit contains the rounding fix, and whether that fix removes the one-pixel column, cannot be established from the available evidence.
Resolution
Provide evidence that commit ac35787a014ddb1c7364aae151a7430f1f8bb2a5 in aurora-wiicompiled contains the scissor and EFB copy rounding change from patchzyy/aurora-wiicompiled#9. Relevant evidence includes the diff of that commit or a test showing the copy clear no longer leaves the black column at non-integer render scales.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 5c2bf88a-5b04-440f-8c20-4640042044e2
Commits
Reviewing files that changed from the base of the PR and between ffbde83 and 796ef52.
Files selected for processing: 1
aurora-main
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps aurora to round scissor and EFB copy rects with the rasterizer's pixel-center rule (patchzyy/aurora-wiicompiled#9), so a copy clear no longer leaves a one-pixel black column next to the quad that redraws it at non-integer render scales.
Fixes #397
Summary by CodeRabbit