Skip to content

Fix black line next to the minimap - #412

Open
patchzyy wants to merge 1 commit into
mainfrom
fix-hud-seam-397
Open

patchzyy wants to merge 1 commit into
mainfrom
fix-hud-seam-397

Conversation

@patchzyy

@patchzyy patchzyy commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Bumps aurora to round scissor and EFB copy rects with the rasterizer's pixel-center rule (patchzyy/aurora-wiicompiled#9), so a copy clear no longer leaves a one-pixel black column next to the quad that redraws it at non-integer render scales.

Fixes #397

Summary by CodeRabbit

  • Chores
    • Updated an internal component reference. The available change details do not indicate any changes to app features or behavior, so no user-facing impact can be confirmed.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The aurora-main submodule pointer changes from commit 33067e34a17ca680eb961d9e0f3d48ddb22a7d7f to ac35787a014ddb1c7364aae151a7430f1f8bb2a5. The submodule contents are not shown.

Changes: Aurora submodule update

Layer / File(s) Summary
Update submodule reference
aurora-main
The submodule pointer now references commit ac35787a014ddb1c7364aae151a7430f1f8bb2a5.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: theofficialgman

Merge Risk: Minimal · up to 796ef

This updates the bundled Aurora graphics library so scissor and copy rectangles are rounded consistently, which is meant to remove the black line near the minimap. No concrete merge-blocking risk was found, though the visual fix itself has not been confirmed in a race.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #397 requires a fix for a black vertical line near the minimap during races. The PR changes only the aurora-main submodule reference, from 33067e34a17ca680eb961d9e0f3d48ddb22a7d7f to ac35787a014… Provide evidence that commit ac35787a014ddb1c7364aae151a7430f1f8bb2a5 in aurora-wiicompiled contains the scissor and EFB copy rounding change from patchzyy/aurora-wiicompiled#9. Relevant evidence includes the diff of that commit or a test s…
Passed Passed checks: 3 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Fix black line next to the minimap" matches the main change. The PR objectives say the change rounds scissor and EFB copy rectangles to stop a one-pixel black column beside the minimap at n…
Out of Scope Changes check Passed The only change in this PR is the aurora-main submodule pointer update, shown as +1/-1 with no declaration changes. The PR description states that this bump delivers the Aurora rounding fix for #397. …
Full details: Title check

Explanation

The title "Fix black line next to the minimap" matches the main change. The PR objectives say the change rounds scissor and EFB copy rectangles to stop a one-pixel black column beside the minimap at non-integer render scales. The title names the symptom and the affected area, but not the mechanism. The only file change is a submodule pointer bump to aurora-main, so the title describes the intent of the change, which the objectives support.

Full details: Out of Scope Changes check

Explanation

The only change in this PR is the aurora-main submodule pointer update, shown as +1/-1 with no declaration changes. The PR description states that this bump delivers the Aurora rounding fix for #397. The change connects directly to the linked issue scope. No unrelated changes are present.

Full details: Linked Issues check

Explanation

Issue #397 requires a fix for a black vertical line near the minimap during races. The PR changes only the aurora-main submodule reference, from 33067e34a17ca680eb961d9e0f3d48ddb22a7d7f to ac35787a014ddb1c7364aae151a7430f1f8bb2a5. The PR description states that the fix rounds scissor and EFB copy rectangles in aurora-wiicompiled#9. The submodule contents are not in the reviewed repository tree, so the rounding change cannot be read here. The PR adds no coding change or automated test in this repository for the minimap glitch. Whether the pinned submodule commit contains the rounding fix, and whether that fix removes the one-pixel column, cannot be established from the available evidence.

Resolution

Provide evidence that commit ac35787a014ddb1c7364aae151a7430f1f8bb2a5 in aurora-wiicompiled contains the scissor and EFB copy rounding change from patchzyy/aurora-wiicompiled#9. Relevant evidence includes the diff of that commit or a test showing the copy clear no longer leaves the black column at non-integer render scales.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c2bf88a-5b04-440f-8c20-4640042044e2
Commits

Reviewing files that changed from the base of the PR and between ffbde83 and 796ef52.

Files selected for processing: 1

  • aurora-main

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Black vertical line near the minimap

1 participant