fix(nodes): wall split and rectangle feedback from the first QA round - #906
Merged
Merged
Conversation
- One wheel notch is one cut. The cut count used to step every 60 px of wheel travel, and a notched wheel on macOS reports a few pixels per notch, so it took three or four notches. A wheel event after an 80 ms pause now steps at once (line-mode events always do); a continuous trackpad stream still steps by travel. - Committing a split, and a merge, plays the wall-placement sound. - The rectangle draft ticks like the line draft: once per snapped corner move, and the line tool's start sound on the first corner, in 3D and 2D. - The wall tool keeps its last shape: re-arming it after rectangle mode resumes rectangle instead of resetting to line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017sG15rKXusC8rbBg6gjSRm
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: 224b8401-8ca4-4298-89fa-5ea50e7fcba2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #902 with the fixes from its first QA round, which landed a minute after the squash merge.
packages/nodes/src/wall/split-pointer.ts).sfx:structure-build).sfx:grid-snaponce per snapped position, and the first corner plays the line tool's start sound, in 3D and in 2D.How to test
bun dev, select a wall, click Split (scissors). Scroll with a notched mouse wheel: each notch changes the cut count by one. A trackpad swipe still changes it smoothly by distance.R(Shape: Rectangle), click the first corner (start sound), then move the mouse: a tick at each new snapped point, as in line mode. Check in 3D and in the 2D plan.bun testinpackages/nodes(new tests cover notched-wheel and trackpad stepping),bun check.Screenshots / screen recording
Mostly feel and sound; a short recording of the notched wheel and the rectangle ticks will be added by the author if useful.
Checklist
bun devbun checkto verify)mainbranch🤖 Generated with Claude Code
https://claude.ai/code/session_017sG15rKXusC8rbBg6gjSRm
Note
Low Risk
Localized UX changes to wall tools, pointer wheel handling, and optional SFX with no auth, data, or core scene-model changes beyond existing split/merge paths.
Overview
QA follow-up for wall split, merge, rectangle drafting, and line/rectangle shape memory.
Wall split scroll now treats each notched-wheel tick as one cut (gesture gap + line-mode deltas), while continuous trackpad scrolling still steps by accumulated travel. Tests cover notched wheels and trackpad streams.
Audio feedback adds
sfx:structure-buildon split commit and wall merge, and aligns rectangle drafting with the line tool: start sound on the first corner andsfx:grid-snapwhen the opposite corner moves to a new snapped position (3D and floor plan).Shape mode no longer resets to Line when the wall tool unmounts; re-selecting the wall tool keeps Rectangle (or Line) for the session.
Reviewed by Cursor Bugbot for commit 9ef12de. Bugbot is set up for automated code reviews on this repo. Configure here.