Fix agent-doc inconsistencies and CI-verify the factory index#108
Merged
Conversation
The hand-written agent docs contradicted the actual API, causing agents to emit non-compiling code or run non-existent commands. Fix the source of the drift and the individual mistakes: - generate-api-reference.java: emit an Element index (tag -> wrapper -> factory methods) derived from the @PlaywrightElement annotation and each wrapper's real static factories. Factory methods are NOT uniform, and this table is now the authoritative, CI-verified list (api-reference.yml already fails stale PRs), preventing element-mapping.md drift. - element-mapping.md: drop the false "every element has get/getByLabel/getById" claim; mark the Key Methods column illustrative and point to the index. - AGENTS.md: fix wrong package (org.vaadin.dramafinder -> org.vaadin.addons.dramafinder) and replace bogus multi-module/spring-boot:run commands with the real single-module -Pit verify flow. - README.md: fix stale sortable-layout-demo module reference. - SKILL.md: correct issue URL vaadin -> parttio. - setup.md: bump KNOWN_LATEST fallback 1.1.1 -> 1.1.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-written agent docs contradicted the actual API, causing agents to emit non-compiling code or run non-existent commands. Fix the source of the drift and the individual mistakes:
factory methods) derived from the @PlaywrightElement annotation and each
wrapper's real static factories. Factory methods are NOT uniform, and this
table is now the authoritative, CI-verified list (api-reference.yml already
fails stale PRs), preventing element-mapping.md drift.
org.vaadin.addons.dramafinder) and replace bogus multi-module/spring-boot:run commands with the real single-module -Pit verify flow.