Fix WiFi credentials clear event not being fired#1580
Open
garzdin wants to merge 1 commit into
Open
Conversation
m-mcgowan
reviewed
Jun 6, 2019
|
|
||
| bool clear_credentials() override | ||
| { | ||
| system_notify_event(network_credentials, network_credentials_cleared); |
Contributor
There was a problem hiding this comment.
I feel I would like to make this conditional on the result of wlan_clear_credentials. We should also check if other Radio interfaces need a similar change. It might be better to add it to the network_clear_credentials() function so that it is ubiquitous?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A WiFi credentials event should be fired when a user calls WiFi.clear_credentials(). It doesn't currently happen.
Solution
A system event is triggered, when a user clears WiFi credentials.
Example App
References
#1570
Completeness