Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AccountId32formats SS58 addresses with prefix 42. Applications displaying chain-specific addresses currently need another encoder or a dependency onsp-core.Changes
to_ss58check_with_prefix(u16), returning an error for reserved or out-of-range prefixes.sp-coreacross prefix boundaries.Validation
Using Rust 1.97.1:
cargo test -p subxt-utils-accountid32 --features sp-core/std,sp-keyring/std --locked— 3 tests and 1 doc test passed.--no-default-features, formatting, and rustdoc with warnings denied passed.The test features enable the existing Substrate dev dependencies on the host.