Skip to content

te feature introduced#88

Open
swasilyev wants to merge 1 commit into
masterfrom
te-feature
Open

te feature introduced#88
swasilyev wants to merge 1 commit into
masterfrom
te-feature

Conversation

@swasilyev

@swasilyev swasilyev commented May 31, 2026

Copy link
Copy Markdown
Contributor

May be temporary, to advance pasta-tree that is SW. Fuck @drskalman. Will break CI where "--no-default-features"

@swasilyev swasilyev requested review from davxy and drskalman May 31, 2026 02:29

@davxy davxy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks more than CI.

  • Feature on -> SW gated out;
  • Feature of -> crate doesn't build

Other concerns:

  • Mutually-exclusive Cargo feature: Features are meant to be additive/unifiable. Any crate pulling w3f-ring-proof with defaults forces twisted_edwards tree-wide; SW consumers can't opt out without --no-default-features. Previously both impls coexisted in one build. This removes that
  • SW tests silently dropped. Under a workspace cargo test feature unification builds w3f-plonk-common with twisted_edwards on, so sw-cond_add (and test) is cfg'd out and stops running with no warning.

Both forms must remain exposed in the same build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants