te feature introduced#88
Open
swasilyev wants to merge 1 commit into
Open
Conversation
davxy
requested changes
Jun 1, 2026
davxy
left a comment
Member
There was a problem hiding this comment.
This breaks more than CI.
- Feature on -> SW gated out;
- Feature of -> crate doesn't build
Other concerns:
- Mutually-exclusive Cargo feature: Features are meant to be additive/unifiable. Any crate pulling w3f-ring-proof with defaults forces
twisted_edwardstree-wide; SW consumers can't opt out without--no-default-features. Previously both impls coexisted in one build. This removes that - SW tests silently dropped. Under a workspace
cargo testfeature unification buildsw3f-plonk-commonwithtwisted_edwardson, sosw-cond_add(and test) is cfg'd out and stops running with no warning.
Both forms must remain exposed in the same build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May be temporary, to advance pasta-tree that is SW. Fuck @drskalman. Will break CI where "--no-default-features"