fix(webrtc): input backpressure#626
Open
gab8i wants to merge 4 commits into
Open
Conversation
lexnv
reviewed
Jun 29, 2026
lexnv
reviewed
Jun 29, 2026
Contributor
Author
|
@lexnv last 3 commits should have addressed your comments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem can be summarized in: inbound messages are forwarded from each
SubstreamHandleto itsSubstreamover a bounded channel using a blockingsend().await, this imply that a slowSubstreamreader can stall the entire connection.Real backpressure though isn't possible, reads come off one shared SCTP association, not per stream. You can't slow down a single reader, you would end up slowing down all substreams (original issue).
So at the end the solution that made more sense to me was to enforce a resource ceiling instead of chasing backpressure.
Earlier attempts added explicit pending-message accounting and pause/resume machinery to emulate some sort of per stream backpressure but at the end they all ended up with a limited buffer waiting to be exceeded. This solution reaches the same point but just with the least change as possible.
Closes #604