Added ruff style guide, pre-commit hook and CI linting and formatting checks#4
Added ruff style guide, pre-commit hook and CI linting and formatting checks#4btijs wants to merge 3 commits into
Conversation
|
Should I also add a small section in the README on how to set up ruff and the commit hooks? |
|
Thanks for the PR! sorry for the delay following up on this ideally could you
that would be great yes! IIUC if someone does not setup the pre-commit hook and pushes the CI should catch that, right? |
Yes, exactly! There are two parts in the CI, the Sancus tests and the ruff tests. The ruff part checks for linting error ( |
Should I clean up the history into a single commit, or a couple (e.g. ruff linting, ruff CI and readme update)? |
Thanks! a couple of commits by topic would prob be best and cleanest 👍 |
Autofix ruff styles Fixed W rules Fixed unused variables Formatted Removed * imports Manually fixed most errors Fixed bare except Added pre-commit hook Removed angr-platforms from git update requirements: add pre-commit and ruff ruff: fix linter warnings Added ruff linting and formatting guidelines and pre-commit-hook
Changed from applying formatting to only check the formatting in pre-commit hook Test invalid ruff formatting Fix invalid ruff formatting Added ruff CI
2 participants
No description provided.