fix: update ts types and lint files#357
Draft
Vicentesan wants to merge 8 commits into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple packages to improve code quality, fix imports, and refine configurations. The most important changes are grouped by theme as follows:
Code Quality Improvements:
packages/databases/src/migrations/migrate/type.ts: Added semicolons to theMigrationsToAddAfterIterationTypetype definition.packages/events/src/events/exceptions.ts: Simplified theNoLayerErrorconstructor message to a single line.packages/server/src/request/index.ts: Removed unnecessary ESLint disable comment forts/ban-types.packages/server/src/utils/error-id.ts: Adjusted the formatting of theperformanceDateassignment for better readability.Import and Export Adjustments:
packages/client/__tests__/test.ts: Changed import ofcoreDomainto a default import and adjusted the order of imports.packages/databases/__tests__/src/drizzle/drizzle.test.ts: ChangedDrizzleDatabaseAdapterimport to a type import and modified theDatabaseAdapterinterface.packages/databases/__tests__/src/sequelize/migrations/index.ts: Standardized the import statement to use single quotes.packages/databases/__tests__/src/standalone/sequelize/database.config.ts: Removed and re-added themigrationsimport to fix formatting issues.Configuration Updates:
packages/client/__tests__/tsconfig.json: UpdatedcompilerOptionsandincludefields to refine TypeScript configuration.These changes collectively enhance the maintainability and readability of the codebase.