feat(gb-test-runner): add standalone acid report#260
Merged
Conversation
pakitovic
force-pushed
the
codex/standalone-acid-report
branch
from
June 18, 2026 11:15
7920542 to
ccf146a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccf146a2fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakitovic
force-pushed
the
codex/standalone-acid-report
branch
from
June 18, 2026 11:33
0c92c8d to
2fef61b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acidreport backed by c-spgame-boy-test-romsv7.0 foldersdmg-acid2,cgb-acid2, andcgb-acid-hell.cargo rom-fetch,cargo rom-suite,cargo rom-report, and ROM report pages without adding atest-roms-extraCI lane.Validation
cargo fmt --checkcargo test -p gb-test-runner built_in_reports_manifest_loads_all_reportscargo test -p gb-test-runner built_in_source_manifests_load_for_each_reportcargo test -p gb-test-runner real_standalone_extra_report_manifests_load_new_runner_oraclescargo rom-suite acidcargo rom-report acid --html