Skip to content

feat(gb-test-runner): add standalone acid report#260

Merged
pakitovic merged 3 commits into
mainfrom
codex/standalone-acid-report
Jun 18, 2026
Merged

feat(gb-test-runner): add standalone acid report#260
pakitovic merged 3 commits into
mainfrom
codex/standalone-acid-report

Conversation

@pakitovic

Copy link
Copy Markdown
Owner

Summary

  • Add a standalone acid report backed by c-sp game-boy-test-roms v7.0 folders dmg-acid2, cgb-acid2, and cgb-acid-hell.
  • Register the report for cargo rom-fetch, cargo rom-suite, cargo rom-report, and ROM report pages without adding a test-roms-extra CI lane.
  • Document the report and cover it in built-in manifest regression tests.

Validation

  • cargo fmt --check
  • cargo test -p gb-test-runner built_in_reports_manifest_loads_all_reports
  • cargo test -p gb-test-runner built_in_source_manifests_load_for_each_report
  • cargo test -p gb-test-runner real_standalone_extra_report_manifests_load_new_runner_oracles
  • cargo rom-suite acid
  • cargo rom-report acid --html
  • Commit hook checks completed successfully, including broader cargo/check advisory validation.

@pakitovic
pakitovic force-pushed the codex/standalone-acid-report branch from 7920542 to ccf146a Compare June 18, 2026 11:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccf146a2fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/gb-test-runner/data/acid/cgb-acid2.suite.toml Outdated
@pakitovic
pakitovic force-pushed the codex/standalone-acid-report branch from 0c92c8d to 2fef61b Compare June 18, 2026 11:33
@pakitovic
pakitovic merged commit 811d804 into main Jun 18, 2026
31 checks passed
@pakitovic
pakitovic deleted the codex/standalone-acid-report branch June 18, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant