Skip to content

fix(ci): package release runtimes before smoke tests#133

Merged
pakitovic merged 4 commits into
mainfrom
codex/fix-release-runtime-packaging
May 12, 2026
Merged

fix(ci): package release runtimes before smoke tests#133
pakitovic merged 4 commits into
mainfrom
codex/fix-release-runtime-packaging

Conversation

@pakitovic

Copy link
Copy Markdown
Owner

Summary

  • smoke-test the Windows executable from the packaged directory after copying runtime DLLs
  • allow Linux and macOS source-build releases to package either static SDL3 output or emitted shared libraries
  • update desktop release docs to describe the packaged-layout smoke-test invariant

Root cause

The v0.1.0 release workflows assumed one SDL3 runtime shape on every platform. Windows ran gb-desktop.exe --help before runtime DLLs were copied into the package directory, while Linux and macOS failed when no libSDL3 shared object was emitted by the SDL3 source-build path.

Validation

  • ruby YAML parse for release Linux/macOS/Windows workflows
  • git diff --check HEAD~1 HEAD
  • repository pre-push hook: cargo fmt-check, cargo lint, typos, cargo deny-check, make coverage-check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a23321a56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release-linux.yml
Comment thread .github/workflows/release-macos.yml
@pakitovic pakitovic merged commit 9df7fb5 into main May 12, 2026
23 checks passed
@pakitovic pakitovic deleted the codex/fix-release-runtime-packaging branch May 12, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant