Dan Meehan Solution#37
Open
dmee3 wants to merge 1 commit into
Open
Conversation
sjreich
reviewed
May 23, 2017
| def booked_guests | ||
| [].tap do |r| | ||
| self.bookings.each { |b| r << b.guest } | ||
| end |
There was a problem hiding this comment.
This is simpler code: self.bookings.map { |booking| booking.guest }. And actually self is redundant here.
But more importantly, this is going to generate a separate query for each guest (an "n+1" problem).
Author
There was a problem hiding this comment.
Oh, good point - I didn't think about function performance while I was adding to the models.
The User.booked_rooms method will run into the same problem then, right?
Member
There was a problem hiding this comment.
I think ActiveRecord's has_many :through association can take care of this for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jaybobo
@erikthiem