✨feat: dark theme on components#1601
Open
maximedasilva wants to merge 22 commits into
Open
Conversation
…/p3ol/oak into feature/dark-theme-on-components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
maximedasilva
changed the title
maximedasilva
changed the title
|
I've found one or more issues in this PR:
Details
Happy coding! |
maximedasilva
force-pushed
the
feature/dark-theme-on-components
branch
from
a322268 to
6ee57ce
Compare
maximedasilva
force-pushed
the
feature/dark-theme-on-components
branch
from
6ee57ce to
4d968d3
Compare
…/p3ol/oak into feature/dark-theme-on-components
maximedasilva
changed the title
dackmin
changed the title
dackmin
requested changes
Jun 10, 2026
| addon.overrides?.forEach(override => { | ||
| this.#overrides.add(override); | ||
| }); | ||
|
|
| ], | ||
| }, | ||
| ], | ||
| }]); |
| export const baseSettings = (): ComponentSettingsFieldObject[] => [ | ||
| stylingSettings(), | ||
| export const baseSettings = ( | ||
| { darkMode = false }: { darkMode?: boolean } = {} |
Member
There was a problem hiding this comment.
create BaseSettingsOptions type and export it
| this.id = props.id; | ||
| this.tab = props.tab; | ||
| this.priority = props.priority; | ||
| this.tab = props.tab; |
Member
There was a problem hiding this comment.
2 times the same line, remove one
| const computeTabs = () => tabs | ||
| .concat( | ||
| (component.settings?.fields || []) | ||
| .filter((f: FieldObject) => f.type === 'tab' && f.tab === undefined) |
| import { useBuilder } from '../hooks'; | ||
| import Setting from './Setting'; | ||
| import SettingsGroup from './SettingsGroup'; | ||
| import Text from '../Text'; |
Member
There was a problem hiding this comment.
move parent imports above relative
| { | ||
| 'oak-max-h-[500px] oak-overflow-y-auto': editableType !== 'modal', | ||
| }, | ||
| { 'oak-pt-px': subtabs?.length > 0 }, |
Member
There was a problem hiding this comment.
just add the property to the same object as above, no need for a new object
| // @ts-expect-error ts & eslint fuckups | ||
| (s.key === f.key || [].concat(s.key) | ||
| .some(k => [].concat(f.key).includes(k))) | ||
| ( |
| ) } | ||
| { subtabs && ( | ||
| <Tabs | ||
| tabs={subtabs.map(subtab => { |
| @@ -302,8 +302,10 @@ export const coreComponentsGroup = (): ComponentsGroupObject => ({ | |||
| components: baseComponents(), | |||
| }); | |||
|
|
|||
Member
There was a problem hiding this comment.
create BaseAddonOptions that extends from BaseSettingsOptions and export it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.