Repository navigation
fix(interaction): handle MoreChunkedMessages in Client.Subscribe - #103
Merged
Merged
Conversation
Client.Subscribe read exactly one ReportData message for the priming report and forwarded each ongoing ReportData message's fragments to Reports as soon as they arrived, never looping on MoreChunkedMessages the way Client.Read already does. A priming or ongoing report that spans more than one ReportData message therefore delivered an incomplete batch instead of one complete report per cycle. Give both the priming-report wait and the ongoing-report goroutine the same accumulate-until-MoreChunkedMessages-false loop, acknowledging each chunk with StatusResponse(Success) as before, so Subscription's "one send = one batch" contract is actually true instead of coincidentally true. Closes #99 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
p0fi
force-pushed
the
fix/99-subscribe-chunking
branch
from
September 16, 2026 21:02
9a6d8e7 to
c5aef1e
Compare
p0fi
added this pull request to stack #102
September 16, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.Subscribepreviously read exactly oneReportDatamessage for the priming report and forwarded each ongoingReportDatamessage straight toReportsas soon as it arrived, without looping onMoreChunkedMessagesthe wayClient.Readalready does.ReportDatamessages — acknowledging each chunk withStatusResponse(Success)as before — untilMoreChunkedMessagesis false/absent, then treat the accumulatedAttributeReportsas one complete batch.Subscription.Reports's "one send = one batch" contract is now actually true instead of coincidentally true.Client.Read,Subscription's public struct shape, orcli/subscribe.go'sbuildSubscribeRecord.Closes #99. This is a prerequisite for #96's Subscribe-side list-chunking reassembly (deferred, out of scope here), so this PR stacks on top of it (
feat/96-list-chunk-reassembly→feat/98-tlv-optional→main).Test plan
TestClient_Subscribe_ChunkedPrimingReport,TestClient_Subscribe_ChunkedOngoingReport,TestClient_Subscribe_ChunkedOngoingReport_EmptyAfterSplitClient.Subscribe/Client.Readtests still pass unmodifiedmise run lintcleanmise run test(full suite, race-enabled) green/code-review(Standards + Spec axes) — no hard violations found🤖 Generated with Claude Code