feat(tlv): add Optional[T] tri-state wrapper for null vs absent - #100
Merged
Merged
Conversation
Encoding a field as TLV null and leaving it off the wire both meant the same thing to the codec: a nil Go pointer. AttributePath.ListIndex needs the distinction (absent = whole list, explicit null = append), so add a generic tlv.Optional[T] with absent/null/value states and wire it into Marshal/Unmarshal, then convert ListIndex to use it. Closes #98 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributePath.ListIndexcouldn't distinguish "whole list" (absent) from "append" (explicit null).tlv.Optional[T]tri-state wrapper (absent / null / value-present) wired intoMarshal/Unmarshal, and convertsAttributePath.ListIndexto use it.Closes #98
Test plan
mise run test(table-driven round-trip tests ininternal/tlv/optional_test.goandinternal/interaction/path_test.go)mise run lintmise run build🤖 Generated with Claude Code