Skip to content

fix: sort partition, track size - #536

Merged
dkharms merged 1 commit into
mainfrom
0-fix-flaky-test
Sep 28, 2026
Merged

dkharms merged 1 commit into
mainfrom
0-fix-flaky-test

Conversation

@dkharms

@dkharms dkharms commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

Description

We had several flaky tests:

  • TestOldestMetrics;
  • TestCapacityExceeded;
  • TestFracInfoCache

They were flaky because we dropped the whole partition even if we drop more than necessary. And we dropped fractions of partition in random order.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter

codecov-commenter commented Sep 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.80%. Comparing base (23a344d) to head (02a5bee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   76.88%   76.80%   -0.09%     
==========================================
  Files         248      248              
  Lines       18808    18810       +2     
==========================================
- Hits        14461    14447      -14     
- Misses       4347     4363      +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin added this to the v0.79.0 milestone Sep 21, 2026
@dkharms
dkharms enabled auto-merge (squash) September 28, 2026 09:43
@dkharms
dkharms merged commit 33d9ec8 into main Sep 28, 2026
10 checks passed
@dkharms
dkharms deleted the 0-fix-flaky-test branch September 28, 2026 09:46
@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
ESBulk-4 23a344 d11b49
348.00 B/op 407.00 B/op 1.17 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants