Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
- Coverage 71.32% 71.22% -0.10%
==========================================
Files 250 251 +1
Lines 21779 21814 +35
==========================================
+ Hits 15533 15538 +5
- Misses 5093 5121 +28
- Partials 1153 1155 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eguguchkin
requested review from
cheb0,
eguguchkin and
forshev
and removed request for
cheb0
September 21, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that we don't account for the time spent waiting on the semaphore. And in general it is impossible to correctly calculate how much time is spent doing nothing -- for example, the previous code miscalculated the waiting time whenever we stalled on the semaphore.
In this pull request I've revisited this code, so that these two cases are much easier to tell apart:
If you have used LLM/AI assistance please provide model name and full prompt: