Skip to content

refactor(query engine): simplify proxy <-> stores streams closing - #532

Merged
forshev merged 1 commit into
mainfrom
0-refactor-streams-closing
Sep 29, 2026
Merged

forshev merged 1 commit into
mainfrom
0-refactor-streams-closing

Conversation

@forshev

@forshev forshev commented Sep 18, 2026

Copy link
Copy Markdown
Member

Description

Simplified proxy <-> stores stream closing logic


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter

codecov-commenter commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.97%. Comparing base (84f72d2) to head (14bb6a3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
proxy/search/stream_search.go 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   76.90%   76.97%   +0.06%     
==========================================
  Files         248      248              
  Lines       18856    18839      -17     
==========================================
  Hits        14501    14501              
+ Misses       4355     4338      -17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin added this to the v0.79.0 milestone Sep 21, 2026
@dkharms

dkharms commented Sep 23, 2026

Copy link
Copy Markdown
Member

The invariant holds -- client must read until io.EOF (or any other error).

@forshev
forshev force-pushed the 0-refactor-streams-closing branch from a08dbdf to 55423c2 Compare September 23, 2026 12:26
@forshev
forshev added this pull request to stack #542 September 24, 2026 14:10
@forshev
forshev removed this pull request from stack #542 September 29, 2026 09:32
@forshev
forshev force-pushed the 0-refactor-streams-closing branch 2 times, most recently from 55423c2 to 14bb6a3 Compare September 29, 2026 09:33
@forshev
forshev enabled auto-merge (squash) September 29, 2026 09:33
@forshev
forshev merged commit c515478 into main Sep 29, 2026
8 checks passed
@forshev
forshev deleted the 0-refactor-streams-closing branch September 29, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants