perf(oxlint/lsp): only invoke lint on code actions when document is not opened by Sysix · Pull Request #24676 · oxc-project/oxc

Sysix · 2026-07-19T15:31:49Z

Some clients can send code actions for documents, which are not opened and already analyzed with a lint process.
A good example is the IntelliJ plugin, which allows the "fix all" code action from the file explorer.

This PR refactors the language-server → tool code-action API to pass a single request struct (including an “is document open” flag), enabling the oxlint LSP linter to avoid re-running lint for code-action requests when the document is already open (and presumably already linted/cached).

This is mostly needed for #23768

Sysix · 2026-07-19T15:32:02Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR refactors the language-server → tool code-action API to pass a single request struct (including an “is document open” flag), enabling the oxlint LSP linter to avoid re-running lint for code-action requests when the document is already open (and presumably already linted/cached).

Changes:

Introduce CodeActionParams (crate-level) and thread it through Backend → WorkspaceWorker → Tool.
Add LSPFileSystem::is_open and use it in Backend::code_action to set is_open_document.
Update oxlint’s ServerLinter code-action path to conditionally run lint based on is_open_document, and adjust tests/call sites accordingly.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_language_server/src/worker.rs	Update worker API to accept `CodeActionParams` instead of separate uri/range/context arguments.
crates/oxc_language_server/src/tool.rs	Change `Tool::get_code_actions_or_commands` to accept `&CodeActionParams`.
crates/oxc_language_server/src/tool_params.rs	Add new `CodeActionParams` struct shared between backend and tools.
crates/oxc_language_server/src/tests.rs	Update fake tool implementation to use `CodeActionParams`.
crates/oxc_language_server/src/lib.rs	Export `CodeActionParams` and register `tool_params` module.
crates/oxc_language_server/src/file_system.rs	Add `is_open(&Uri)` helper used by backend for open-document detection.
crates/oxc_language_server/src/backend.rs	Build and forward tool `CodeActionParams` including `is_open_document`.
apps/oxlint/src/lsp/tester.rs	Update tester to call linter with `CodeActionParams`.
apps/oxlint/src/lsp/server_linter.rs	Use `is_open_document` to avoid running lint for invoked code actions when the document is open; update tests/helpers accordingly.

camc314 · 2026-07-19T17:15:54Z

Merge activity

Jul 19, 5:15 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 19, 5:15 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jul 19, 5:20 PM UTC: Merged by the Graphite merge queue.

…ot opened (#24676) Some clients can send code actions for documents, which are not opened and already analyzed with a lint process. A good example is the IntelliJ plugin, which allows the "fix all" code action from the file explorer. > This PR refactors the language-server → tool code-action API to pass a single request struct (including an “is document open” flag), enabling the oxlint LSP linter to avoid re-running lint for code-action requests when the document is already open (and presumably already linted/cached). This is mostly needed for #23768

# Oxlint ### 💥 BREAKING CHANGES - 54cc121 ast: [**BREAKING**] Split `MetaProperty` into `ImportMeta` and `NewTarget` (#24557) (camc314) ### 🚀 Features - 7b045cd minfier: Drop last break from last switch case (#24673) (Armano) - dd18383 linter/node: Implement no-top-level-await rule (#24634) (Connor Shea) - 16a65f2 linter/react: Implement function-component-definition rule (#24471) (Cole Ellison) - 7f1f585 linter: Reuse `jest/padding-around-test-blocks` for `vitest/padding-around-test-blocks` (#24519) (Mikhail Baev) - 99978a8 linter/import/consistent-type-specifier-style: Support `prefer-top-level-if-only-type-imports` option (#24502) (camc314) ### 🐛 Bug Fixes - 0184ad6 linter/unicorn/no-useless-undefined: Preserve valid parameter defaults (#24686) (camc314) - 8694167 linter/eslint/prefer-destructuring: Handle typed declarations (#24616) (camc314) - 477cf0f linter/eslint/no-throw-literal: Handle assigned errors (#24561) (Cole Ellison) - ac9200a linter: Detect React components from returned JSX (#24521) (camc314) - c0a6522 linter/eslint/no-useless-computed-key: Allow TS syntax in computed keys (#24524) (Cole Ellison) ### ⚡ Performance - 346eed1 linter/unicorn/prefer-event-target: Only run on `Class` and `NewExpression` nodes (#24685) (Mikhail Baev) - 7be5cf0 oxlint/lsp: Only invoke lint on code actions when document is not opened (#24676) (Sysix) - d3f07a0 diagnostics: Box OxcDiagnosticInner to reduce binary size (#24665) (Boshen) - 90ae040 linter/reporter/stylish: Compute diagnostic Info once per diagnostic (#24525) (connorshea) ### 📚 Documentation - e6f7174 linter/valid-expect: Fix correct example being identical to incorrect one (#24468) (mkan0141) # Oxfmt ### 💥 BREAKING CHANGES - 54cc121 ast: [**BREAKING**] Split `MetaProperty` into `ImportMeta` and `NewTarget` (#24557) (camc314) ### 🚀 Features - 3d22307 parser: Add `ParseOptions::enable_ident_hashes` (#24491) (Boshen) ### 🐛 Bug Fixes - 6fe866a oxfmt: Keep tailwind classes glued to template expr with `preserveWhitespace` (#24609) (leaysgur) - 33e32d8 formatter_css: Use `line_suffix` for EOL line comment (#24580) (leaysgur) - 5f76998 formatter_graphql: Keep same line comments pending across intervening tokens (#24579) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>

github-actions Bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server labels Jul 19, 2026

Sysix requested a review from Copilot July 19, 2026 15:33

Copilot started reviewing on behalf of Sysix July 19, 2026 15:34 View session

Copilot AI reviewed Jul 19, 2026

View reviewed changes

Comment thread crates/oxc_language_server/src/backend.rs

Comment thread apps/oxlint/src/lsp/server_linter.rs

Sysix marked this pull request as ready for review July 19, 2026 16:35

Sysix requested review from camc314 and leaysgur as code owners July 19, 2026 16:35

Sysix assigned camc314 Jul 19, 2026

camc314 approved these changes Jul 19, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 19, 2026

graphite-app Bot force-pushed the 07-19-perf_oxlint_lsp_only_invoke_lint_on_code_actions_when_document_is_not_opened branch from a157d1a to 7be5cf0 Compare July 19, 2026 17:16

graphite-app Bot merged commit 7be5cf0 into main Jul 19, 2026
29 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 19, 2026

graphite-app Bot deleted the 07-19-perf_oxlint_lsp_only_invoke_lint_on_code_actions_when_document_is_not_opened branch July 19, 2026 17:20

oxc-guard Bot mentioned this pull request Jul 20, 2026

release(apps): oxlint v1.75.0 && oxfmt v0.60.0 #24713

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(oxlint/lsp): only invoke lint on code actions when document is not opened#24676

perf(oxlint/lsp): only invoke lint on code actions when document is not opened#24676
graphite-app[bot] merged 1 commit into
mainfrom
07-19-perf_oxlint_lsp_only_invoke_lint_on_code_actions_when_document_is_not_opened

Sysix commented Jul 19, 2026 •

edited

Loading

Uh oh!

Sysix commented Jul 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jul 19, 2026 •

edited by graphite-app Bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Sysix commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Jul 19, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Jul 19, 2026 • edited by graphite-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Jul 19, 2026 •

edited

Loading

camc314 commented Jul 19, 2026 •

edited by graphite-app Bot

Loading