Skip to content

ci: use codspeed mode input#383

Merged
Boshen merged 1 commit into
mainfrom
ci/codspeed-mode-simulation
Jun 26, 2026
Merged

ci: use codspeed mode input#383
Boshen merged 1 commit into
mainfrom
ci/codspeed-mode-simulation

Conversation

@Boshen

@Boshen Boshen commented Jun 26, 2026

Copy link
Copy Markdown
Member

Replaces the CodSpeed simulation input with mode: simulation.

@Boshen Boshen marked this pull request as ready for review June 26, 2026 08:45
@Boshen Boshen merged commit 9efb83b into main Jun 26, 2026
6 checks passed
@Boshen Boshen deleted the ci/codspeed-mode-simulation branch June 26, 2026 08:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 112a471088

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

timeout-minutes: 15
with:
simulation: true
mode: simulation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the duplicate CodSpeed mode key

This step now has two mode entries in the same with map: this line and the existing mode: instrumentation two lines later. YAML mapping keys must be unique, and parsers that tolerate duplicates keep only one value; with the later key winning, the newly added simulation setting is not what the pinned CodSpeed action receives. Drop the old mode: instrumentation so the workflow is unambiguous.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant