Log successful requests at debug to cut empty info log spam#116
Open
stephenzora wants to merge 1 commit into
Open
Log successful requests at debug to cut empty info log spam#116stephenzora wants to merge 1 commit into
stephenzora wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request logging middleware logs every request at info with an empty message, about 90 lines per minute in the Datadog live tail with no message text to scan.
Successful requests now log at debug, which the prod info level filters out. Requests with status 400 and above keep info so failures still surface. The line also gains a message and the request path so the entries that do appear are readable.
Refs BPF-1905