Skip to content

Revert to render site temporarily#10

Merged
avahoffman merged 1 commit into
mainfrom
bugfix/render
May 16, 2025
Merged

Revert to render site temporarily#10
avahoffman merged 1 commit into
mainfrom
bugfix/render

Conversation

@avahoffman

@avahoffman avahoffman commented May 16, 2025

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented May 16, 2025

Copy link
Copy Markdown
Contributor

OTTR Check Results

Summary

  • Spelling check: ✅ PASSED (0 errors found, threshold: 0)
  • URL check: ❌ FAILED (16 errors found, threshold: 0)

⚠️ Some Checks Failed Click here to download detailed error reports

Last Updated: 2025-05-16-20:38:58

Comment on lines +23 to +39
name: Load user automation choices
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

# Use the yaml-env-action action.
- name: Load environment from YAML
uses: doughepi/yaml-env-action@v1.0.0
with:
files: config_automation.yml # Pass a space-separated list of configuration files. Rightmost files take precedence.

outputs:
rendering_docker_image: "${{ env.RENDERING_DOCKER_IMAGE }}"

# This workflow contains a single job called "build-all"
render-main:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 year ago

To fix the issue, we will add a permissions block to the workflow. This block will specify the minimal permissions required for the workflow to function correctly. Based on the workflow's actions, it needs contents: write to commit changes to the repository and possibly contents: read for other operations. We will add the permissions block at the root level of the workflow to apply to all jobs unless overridden.

Suggested changeset 1
.github/workflows/render-site.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/render-site.yml b/.github/workflows/render-site.yml
--- a/.github/workflows/render-site.yml
+++ b/.github/workflows/render-site.yml
@@ -6,2 +6,4 @@
 name: Render html
+permissions:
+  contents: write
 
EOF
@@ -6,2 +6,4 @@
name: Render html
permissions:
contents: write

Copilot is powered by AI and may make mistakes. Always verify output.
Comment on lines +40 to +83
needs: yaml-check
runs-on: ubuntu-latest
container:
image: ${{needs.yaml-check.outputs.rendering_docker_image}}

steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: checkout
uses: actions/checkout@v4
with:
# get the full repo
fetch-depth: 0
# use github PAT
token: ${{ secrets.GH_PAT }}

# We want a fresh run of the renders each time - so first delete old html files
- name: Delete old *.html
run: Rscript -e "rmarkdown::clean_site(preview = FALSE)"

# Now we want to render all the html files from the Rmd files
- name: Run render html
id: site
run: Rscript -e "rmarkdown::render_site()"

# This checks on the steps before it and makes sure that they completed.
# If the renders didn't complete we don't want to commit the file changes
- name: Check on render steps
if: steps.site.outcome != 'success'
run: |
echo site status ${{steps.site.outcome}}
exit 1

# Commit the rendered site files - html files and site_libs files
# The git reset step will remove any other files created in this workflow, such as API keys
- name: Commit rendered site files
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
git config --global user.name 'github-actions[bot]'
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
git add --force docs/*
git commit -m 'Render site' || echo "No changes to commit"
git reset --hard HEAD
git pull --rebase --allow-unrelated-histories --strategy-option=ours
git push origin main || echo "No changes to push"

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 year ago

To fix the issue, we will add a permissions block to the workflow. This block will be added at the root level to apply to all jobs in the workflow. Based on the workflow's operations, the minimal required permissions are contents: read for reading repository content and contents: write for committing rendered site files. We will also ensure no unnecessary permissions are granted.


Suggested changeset 1
.github/workflows/render-site.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/render-site.yml b/.github/workflows/render-site.yml
--- a/.github/workflows/render-site.yml
+++ b/.github/workflows/render-site.yml
@@ -6,2 +6,4 @@
 name: Render html
+permissions:
+  contents: write
 
EOF
@@ -6,2 +6,4 @@
name: Render html
permissions:
contents: write

Copilot is powered by AI and may make mistakes. Always verify output.
@github-actions

Copy link
Copy Markdown
Contributor

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2025-05-16 with changes from the latest commit eec9375

@avahoffman avahoffman merged commit 2915110 into main May 16, 2025
6 of 7 checks passed
@avahoffman avahoffman deleted the bugfix/render branch May 16, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants