Skip to content

suggestions from review#14

Open
padmashris wants to merge 9 commits into
mainfrom
review_updates
Open

suggestions from review#14
padmashris wants to merge 9 commits into
mainfrom
review_updates

Conversation

@padmashris

@padmashris padmashris commented May 7, 2026

Copy link
Copy Markdown
  • adding back Google Forms and Slido
  • filling out the remaining subsections on the homepage
  • updating template URL

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

OTTR Check Results

Summary

  • Spelling check: ✅ PASSED (0 errors found, threshold: 0)
  • URL check: ✅ PASSED (0 errors found, threshold: 0)

🎉 All checks passed!

Last Updated: 2026-06-10-14:56:09

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2026-06-10 with changes from the latest commit f33e5c2

@padmashris padmashris requested a review from carriewright11 May 13, 2026 18:54
@carriewright11

Copy link
Copy Markdown
Contributor

Looks good to me! @kweav what do you think? I know we need to add some disclaimers about what functionality is still in the works for some of these, but I do think it is good to set this up as is and add a box to those once we have tested some more.

Comment thread index.Rmd Outdated
Comment thread index.Rmd Outdated
Comment thread index.Rmd Outdated

### Setting up GitHub

At this point you should already have your GitHub authorization set up for your metricminer dashboard by having [followed the instructions above](#setting-up-your-dashboard-repository).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update this since a second secret is what metricminer expects METRICMINER_GITHUB_PAT for fetching data from GitHub while OTTR expects the GH_PAT for just general OTTR tasks (checks and rendering)

Comment thread index.Rmd
https://drive.google.com/drive/u/1/folders/<SOME_FOLDER_ID_HERE>
```

Put the folder ID from this URL in the `drive_id` category in the `_config_automation.yml` file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a drive name instead of a drive_id now because of the changes we had to make to the function

@kweav

kweav commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Made some comments on the instructions.

As for the specific pages/preview (like Google Forms)--

  1. should we add a note that metricminer isn't going to remove any identifying information that may be included (like in Slido or Calendly meeting notes, etc.)
  2. The google forms one still has that bug where the question names aren't part of the metricminer results output, but I know we're working on a fix for that
  3. I was really surprised that slido was getting data to display but went looking and it's using 2 year old data. A couple of notes -- we'll need a drive name instead of a drive ID to get new data. I don't have access to the drive ID that is listed in the refresh script, so I can set up another test drive and put test data there if needed

@carriewright11

Copy link
Copy Markdown
Contributor

Made some comments on the instructions.

As for the specific pages/preview (like Google Forms)--

  1. should we add a note that metricminer isn't going to remove any identifying information that may be included (like in Slido or Calendly meeting notes, etc.)

  2. The google forms one still has that bug where the question names aren't part of the metricminer results output, but I know we're working on a fix for that

  3. I was really surprised that slido was getting data to display but went looking and it's using 2 year old data. A couple of notes -- we'll need a drive name instead of a drive ID to get new data. I don't have access to the drive ID that is listed in the refresh script, so I can set up another test drive and put test data there if needed

Thanks for these comments! Yes, I think we should mention all of this. I think Padma can add this and do more Slido tests too

@jhudsl-robot

jhudsl-robot commented Jun 10, 2026

Copy link
Copy Markdown

Overall readability score: 52.48 (🔴 -0.37)

File Readability
README.md 78.6 (🔴 -0.73)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
README.md 78.6 57.06 7.34 9 9.62 5.69
  🔴 -0.73 🔴 -0.1 🔴 -0.09 🔴 -0.2 🔴 -0.17 🔴 -0.01

Averages:

  Readability FRE GF ARI CLI DCRS
Average 52.48 30.52 10.85 12.65 13.57 7.2
  🔴 -0.37 🔴 -0.05 🔴 -0.04 🔴 -0.1 🔴 -0.09 🔴 -0.01
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants