suggestions from review#14
Conversation
OTTR Check ResultsSummary
🎉 All checks passed!Last Updated: 2026-06-10-14:56:09 |
|
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2026-06-10 with changes from the latest commit f33e5c2 |
|
Looks good to me! @kweav what do you think? I know we need to add some disclaimers about what functionality is still in the works for some of these, but I do think it is good to set this up as is and add a box to those once we have tested some more. |
|
|
||
| ### Setting up GitHub | ||
|
|
||
| At this point you should already have your GitHub authorization set up for your metricminer dashboard by having [followed the instructions above](#setting-up-your-dashboard-repository). |
There was a problem hiding this comment.
We'll need to update this since a second secret is what metricminer expects METRICMINER_GITHUB_PAT for fetching data from GitHub while OTTR expects the GH_PAT for just general OTTR tasks (checks and rendering)
| https://drive.google.com/drive/u/1/folders/<SOME_FOLDER_ID_HERE> | ||
| ``` | ||
|
|
||
| Put the folder ID from this URL in the `drive_id` category in the `_config_automation.yml` file. |
There was a problem hiding this comment.
I think we need a drive name instead of a drive_id now because of the changes we had to make to the function
|
Made some comments on the instructions. As for the specific pages/preview (like Google Forms)--
|
Thanks for these comments! Yes, I think we should mention all of this. I think Padma can add this and do more Slido tests too |
Co-Authored-By: Kate Isaac <41767733+kweav@users.noreply.github.com>
|
Overall readability score: 52.48 (🔴 -0.37)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
Uh oh!
There was an error while loading. Please reload this page.