Skip to content

Bugfix - Periodic URL checker#22

Merged
avahoffman merged 29 commits into
mainfrom
fix-periodic-checker
Jun 16, 2025
Merged

Bugfix - Periodic URL checker#22
avahoffman merged 29 commits into
mainfrom
fix-periodic-checker

Conversation

@avahoffman

@avahoffman avahoffman commented May 30, 2025

Copy link
Copy Markdown
Contributor

Periodic URL checker was failing for a few reasons:

  • It was running on base_ottr, not with ubuntu-latest, and therefore didn't have the docker command line tools.
  • The new ottr-reports makes an artifact, which wasn't clearly available to the rest of the workflow

Solution:

I broke down the ottr-reports and issue creation into separate jobs. This is a little cleaner because if ottr-reports succeeds, then it doesn't proceed to the issue creation step, create a branch with the errors, etc.

Examples:


Related: ottrproject/ottrproject.github.io#5

Resolves #21

@github-actions

github-actions Bot commented May 30, 2025

Copy link
Copy Markdown
Contributor

OTTR Check Results

Summary

  • Spelling check: ✅ PASSED (0 errors found, threshold: 0)
  • URL check: ✅ PASSED (0 errors found, threshold: 0)

🎉 All checks passed!

Last Updated: 2025-06-12-20:12:53

@github-actions

github-actions Bot commented May 30, 2025

Copy link
Copy Markdown
Contributor

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2025-06-12 with changes from the latest commit d148902

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the file used to test my theory.

@avahoffman avahoffman marked this pull request as draft June 5, 2025 21:19
Comment thread .github/workflows/check-url.yml Fixed
Comment thread .github/workflows/check-url.yml Fixed
Comment thread .github/workflows/check-url.yml Fixed
@avahoffman avahoffman marked this pull request as ready for review June 12, 2025 19:26
@kweav

kweav commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

This is so cool -- thanks!! And the tests look great --

  1. Any tests or specific proofreading I can help with?
  2. Any corresponding documentation changes I should make over on ottrproject.org?

@kweav

kweav commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Do we want the issue template to assign someone to the broken URL issue so we see it faster? Or because courses using the template would inherit that, not so much? Is there a way to easily assign someone with the config file -- and have people update their config files to change it from us to them?

@carriewright11

carriewright11 commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Do we want the issue template to assign someone to the broken URL issue so we see it faster? Or because courses using the template would inherit that, not so much? Is there a way to easily assign someone with the config file -- and have people update their config files to change it from us to them?

I think this could be cool to allow people to put someone, a default is a bit odd though - maybe possible to leave blank

I also noticed that it doesn't use the config limits for errors

@avahoffman

Copy link
Copy Markdown
Contributor Author

Any corresponding documentation changes I should make over on ottrproject.org?

@kweav I think the functionality should be similar but we could always update screenshots if any. Perhaps make an issue in the website repo so we don't forget?

I also noticed that it doesn't use the config limits for errors

We can easily use the config file! Will do.

Do we want the issue template to assign someone to the broken URL issue so we see it faster?

Maybe? Could we make an issue for this as an "enhancement" follow up?

@cansavvy cansavvy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me!

@avahoffman avahoffman merged commit 2ca00cd into main Jun 16, 2025
11 checks passed
@avahoffman avahoffman deleted the fix-periodic-checker branch June 16, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete temporary url checker created for testing

5 participants