Bugfix - Periodic URL checker#22
Conversation
OTTR Check ResultsSummary
🎉 All checks passed!Last Updated: 2025-06-12-20:12:53 |
|
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2025-06-12 with changes from the latest commit d148902 |
There was a problem hiding this comment.
This was the file used to test my theory.
|
This is so cool -- thanks!! And the tests look great --
|
|
Do we want the issue template to assign someone to the broken URL issue so we see it faster? Or because courses using the template would inherit that, not so much? Is there a way to easily assign someone with the config file -- and have people update their config files to change it from us to them? |
I think this could be cool to allow people to put someone, a default is a bit odd though - maybe possible to leave blank I also noticed that it doesn't use the config limits for errors |
@kweav I think the functionality should be similar but we could always update screenshots if any. Perhaps make an issue in the website repo so we don't forget?
We can easily use the config file! Will do.
Maybe? Could we make an issue for this as an "enhancement" follow up? |
cansavvy
left a comment
There was a problem hiding this comment.
This looks reasonable to me!
Periodic URL checker was failing for a few reasons:
base_ottr, not withubuntu-latest, and therefore didn't have the docker command line tools.Solution:
I broke down the
ottr-reportsand issue creation into separate jobs. This is a little cleaner because ifottr-reportssucceeds, then it doesn't proceed to the issue creation step, create a branch with the errors, etc.Examples:
Related: ottrproject/ottrproject.github.io#5
Resolves #21